Skip to content

Fix geopandas CRS warning#1810

Merged
visr merged 2 commits into
mainfrom
crs-warn
Sep 10, 2024
Merged

Fix geopandas CRS warning#1810
visr merged 2 commits into
mainfrom
crs-warn

Conversation

@visr
Copy link
Copy Markdown
Member

@visr visr commented Sep 9, 2024

Fixes #1799
This looks into the parent class to set the CRS of the Node table directly after it is created.
That means we also don't have to do this (and create an extra copy) each time we call node_table.

@evetion
Copy link
Copy Markdown
Member

evetion commented Sep 9, 2024

Thanks for fixing this, I forgot to make an issue after @DanielTollenaar mentioned this warning. LGTM, but this means we can remove the set_crs from the write method, and from

df_chunks = [node.node.df.set_crs(self.crs) for node in self._nodes()]
as well.

@visr visr merged commit a04ef5b into main Sep 10, 2024
@visr visr deleted the crs-warn branch September 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Geopandas concat CRS warning

2 participants