Skip to content

Save all results via saving callback (follow up)#1896

Merged
visr merged 8 commits intomainfrom
save_all_results_via_saving_callback
Oct 10, 2024
Merged

Save all results via saving callback (follow up)#1896
visr merged 8 commits intomainfrom
save_all_results_via_saving_callback

Conversation

@SouthEndMusic
Copy link
Collaborator

@SouthEndMusic SouthEndMusic commented Oct 10, 2024

This is a follow up of #1825 (and a few unrelated experiments).

Fixes #1837.

Other changes in this PR:

  • Storages from the cumulative flows are computed as a sparse matrix-vector product
  • Storage rates are computed without involving the initial storage
  • Manning resistance is more stable around $\Delta h = 0$.

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. If you could add some unit tests for flow_to_storage, this can go in.

@evetion
Copy link
Member

evetion commented Oct 10, 2024

  • Manning resistance is more stable around Δ h = 0 .

IMHO, that is an (important! 🎉) change that should not be committed by a squashed commit called save all results via saving callback.

@visr visr merged commit cf73c99 into main Oct 10, 2024
@visr visr deleted the save_all_results_via_saving_callback branch October 10, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid re-computing the water balance error

3 participants