Save all results via saving callback (follow up)#1896
Merged
Conversation
…g punt truncation errors when storage0 >> cumulative flow)
…ady state easier to find)
visr
approved these changes
Oct 10, 2024
Member
visr
left a comment
There was a problem hiding this comment.
This looks good to me. If you could add some unit tests for flow_to_storage, this can go in.
Member
IMHO, that is an (important! 🎉) change that should not be committed by a squashed commit called |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up of #1825 (and a few unrelated experiments).
Fixes #1837.
Other changes in this PR: