Fix duplicate boundaries in Delwaq generation. - #1903
Merged
Conversation
Member
|
Looks good to me overall. I think we should remove the 3 print statements, since this is a valid Ribasim model. |
Member
Author
|
I will make the prints debug, and the warnings errors, that should trigger one such a thing happens again in the tests. |
Member
Author
There are several warnings (that we can safely ignore) in the output file, so that's hard to test. I'd say if it runs, it runs 🤷🏻 (and we can parse the output). Let's revisit this when we bundle/wrap Delwaq. |
visr
approved these changes
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1901
Fixes #1902
This disables any dispersion in the Delwaq model, fixing some tracer intrusions.
#1902 was actually two issues: