Add step_limiter! to avoid negative flows or too large flows - #1911
Merged
Conversation
SouthEndMusic
marked this pull request as draft
October 21, 2024 09:37
SouthEndMusic
marked this pull request as ready for review
October 21, 2024 09:43
evetion
approved these changes
Oct 21, 2024
Merged
SouthEndMusic
added a commit
that referenced
this pull request
Oct 25, 2024
Follow-up of #1911. Fixes #1897 (?). Fixes #1838 (how could we test that negative flows where they should not be no longer occur? Maybe add a callback that explicitly checks for non-decreasing states) I focus in this PR on `UserDemand` inflow and infiltration because of their importance in coupling. --------- Co-authored-by: Martijn Visser <mgvisser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1900. Split out of #1904.