Skip to content

[WQ] Drop duplicate boundaries instead of making them unique.#1917

Merged
evetion merged 1 commit intomainfrom
fix/fix-delwaq-duplicate-boundary
Oct 24, 2024
Merged

[WQ] Drop duplicate boundaries instead of making them unique.#1917
evetion merged 1 commit intomainfrom
fix/fix-delwaq-duplicate-boundary

Conversation

@evetion
Copy link
Member

@evetion evetion commented Oct 23, 2024

Found while debugging the LHM model. A tracer was added, but didn't show up in Delwaq because the boundary list (bndlist) was shifted after duplicate UserDemand edges.

Also added more information to the generated.csv files for debugging.

@evetion evetion changed the title Drop duplicate boundaries instead of making them unique. [WQ] Drop duplicate boundaries instead of making them unique. Oct 23, 2024
@evetion evetion added the waterquality Issues related to Delwaq coupling/functionality label Oct 23, 2024
@evetion evetion requested a review from SouthEndMusic October 23, 2024 14:13
Copy link
Collaborator

@SouthEndMusic SouthEndMusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was convinced that this is good (:

@evetion evetion merged commit 180f283 into main Oct 24, 2024
@evetion evetion deleted the fix/fix-delwaq-duplicate-boundary branch October 24, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waterquality Issues related to Delwaq coupling/functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants