Fix test_version during release process and simplify versions in README.md#1938
Merged
Conversation
The `core_version` is like the `version`, but no info on dirty or post-tag status. The julia_version can be looked up from the commit, and is generally not very relevant for users.
evetion
approved these changes
Nov 18, 2024
Member
|
I restarted all builds on TC (were crashing because the disk was full), otherwise LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the README.md we had version info like this:
This cuts it down to just this:
Where
tagis of the form2024.10.0-128-ge09eeb5if it is after tag v2024.10.0, otherwise just2024.10.0The
test_versionjust checks the form, because we bump the versions before doing a git tag, so they can be off by one version temporarily. I think that's simpler than introducing more difficult logic inset_versionto handle this.Fixes #1655