Skip to content

Fix test_version during release process and simplify versions in README.md#1938

Merged
visr merged 4 commits into
mainfrom
bad-version
Nov 18, 2024
Merged

Fix test_version during release process and simplify versions in README.md#1938
visr merged 4 commits into
mainfrom
bad-version

Conversation

@visr

@visr visr commented Nov 15, 2024

Copy link
Copy Markdown
Member

In the README.md we had version info like this:

release = "$tag"
commit = "$url/$short_commit"
branch = "$url/$short_name"
julia_version = "$julia_version"
core_version = "$version"

This cuts it down to just this:

version = "$tag"
commit = "$url/$short_commit"
branch = "$url/$short_name"

Where tag is of the form 2024.10.0-128-ge09eeb5 if it is after tag v2024.10.0, otherwise just 2024.10.0
The test_version just checks the form, because we bump the versions before doing a git tag, so they can be off by one version temporarily. I think that's simpler than introducing more difficult logic in set_version to handle this.

Fixes #1655

visr added 3 commits November 15, 2024 11:49
The `core_version` is like the `version`, but no info on dirty or post-tag status. The julia_version can be looked up from the commit, and is generally not very relevant for users.
@visr
visr requested a review from evetion November 15, 2024 11:29
@evetion

evetion commented Nov 18, 2024

Copy link
Copy Markdown
Member

I restarted all builds on TC (were crashing because the disk was full), otherwise LGTM.

@visr
visr merged commit fe3b789 into main Nov 18, 2024
@visr
visr deleted the bad-version branch November 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore test_version on version bump PR

2 participants