Get rid of specifying sources in allocation by edges - #1956
Merged
Conversation
SouthEndMusic
marked this pull request as ready for review
November 28, 2024 16:10
visr
added a commit
to Deltares/Ribasim-NL
that referenced
this pull request
Dec 2, 2024
As of Deltares/Ribasim#1956 these are automatically inferred.
visr
reviewed
Dec 2, 2024
visr
approved these changes
Dec 3, 2024
visr
added a commit
to Deltares/Ribasim-NL
that referenced
this pull request
Dec 9, 2024
As of Deltares/Ribasim#1956 these are automatically inferred.
visr
added a commit
that referenced
this pull request
Dec 20, 2024
Fixes #1978 In #1956 we forgot to update the schema version. Due to this line: https://github.com/Deltares/Ribasim/blob/18217f0a0065e93c076ee663db4f6f2057c139b1/python/ribasim/ribasim/input_base.py#L177 That means migration functions aren't called. This fixes that. I also added some extra comments on keeping them synced, and make the schema version checks a bit more consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1953.
To do: come up with a unified way to handle deprecation, and incorporate this in the developer docs and release process. Maybe also use a 'deprecation' label instead of a 'breaking' label?