Add Basin / subgrid_time table#1975
Merged
Merged
Conversation
visr
marked this pull request as ready for review
December 16, 2024 15:25
evetion
reviewed
Dec 17, 2024
evetion
left a comment
evetion
left a comment
Member
There was a problem hiding this comment.
Can you document the construction of the new interpolation objects? That inner loop is opaque to me (with complexted indexlookups etc).
| cache_parameters = true, | ||
| ) | ||
| # # These should only be pushed when the subgrid_id has changed | ||
| if subgrid_id_time[end] != subgrid_id |
Member
There was a problem hiding this comment.
Hmmm, not sure if I get it, but if we group by subgrid_id, this will always be true?
visr
commented
Dec 17, 2024
visr
commented
Dec 17, 2024
Co-authored-by: Maarten Pronk <git@evetion.nl>
evetion
approved these changes
Dec 20, 2024
Member
|
Friday afternoon eh. You better not make a release after this, but enjoy the weekend 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1010
This adds
Basin / subgrid_time. So far the only relation we could update over time wasQ(h)(TabulatedRatingCurve / time), and that is implemented differently. I wrote #1976 to get those more in line. It's good to read that since it explains the implementation here.Things I dislike:
Basin / subgrid_time, just likeBasin / concentration_.Basin / static,Basin / time. Since we already haveBasin / subgridwe cannot do that.