Implement model equality#2057
Merged
Merged
Conversation
visr
approved these changes
Feb 13, 2025
visr
left a comment
visr
left a comment
Member
There was a problem hiding this comment.
Great! Left a few comments, but looks good otherwise.
Comment on lines
+118
to
+138
| if self.__dict__ == other.__dict__: | ||
| return True | ||
|
|
||
| model_fields = type(self).__pydantic_fields__.keys() | ||
| if ( | ||
| self.__dict__.keys() <= model_fields | ||
| and other.__dict__.keys() <= model_fields | ||
| ): | ||
| return False | ||
|
|
||
| getter = ( | ||
| operator.itemgetter(*model_fields) | ||
| if model_fields | ||
| else lambda _: pydantic._utils._SENTINEL # type: ignore | ||
| ) | ||
| try: | ||
| return getter(self.__dict__) == getter(other.__dict__) | ||
| except KeyError: | ||
| self_fields_proxy = pydantic._utils.SafeGetItemProxy(self.__dict__) # type: ignore | ||
| other_fields_proxy = pydantic._utils.SafeGetItemProxy(other.__dict__) # type: ignore | ||
| return getter(self_fields_proxy) == getter(other_fields_proxy) |
Member
There was a problem hiding this comment.
Could you add some comments here, because I can't follow.
If their __dict__ is not equal, they can still be equal?
Member
Author
There was a problem hiding this comment.
You're reviewing Pydantic code, let's not do that. I will clarify this with a better (license) header.
Co-authored-by: Martijn Visser <mgvisser@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #928
Partially solves Deltares/Ribasim-NL#229
Differences, and such will follow in a separate PR.