Merged
Conversation
evetion
approved these changes
Feb 20, 2025
Member
evetion
left a comment
evetion
left a comment
There was a problem hiding this comment.
Nice work, also in terms of reducing/simplifying code used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #744
Notable changes:
condition_idand an optionaltimecolumn were added to theDiscreteControl / conditiontable. Sorting of this table is no longer based onnode_id, compound_variable_id, greater_thanbut onnode_id, compound_variable_id, condition_idgreater_thantimeseries were added to thetstops