Coerce geometries to 2D

[visr]

Doesn't seem to be working yet. Handing over to @evetion.
Fixes #2103.

import ribasim

m1 = ribasim.Model.read("a/ribasim.toml")
m1.discrete_control.node.df.geometry = m1.discrete_control.node.df.geometry.force_3d()
m1.write("b/ribasim.toml")
m2 = ribasim.Model.read("b/ribasim.toml")
m2.discrete_control.node.df  # still 3D :(

https://pandera.readthedocs.io/en/stable/data_format_conversion.html

edit: We want parse as documented here.

[visr]

Nice, thanks. Would approve if I could ;)

[evetion]

Approved ;) But please check manually if it works on a problematic model before merging.

[visr]

Hmm this doesn't seem to work on reading a model with 3D geometries, like in the example above.

[evetion]

Can you send me your 3d model?

[visr]

I'm not sure which one is 3D and which one isn't, but doesn't my snippet reproduce for you? This works on any generated testmodel.

[evetion]

I'm not sure which one is 3D and which one isn't, but doesn't my snippet reproduce for you? This works on any generated testmodel.

Can't reproduce:

In [8]: m1.discrete_control.node
Out[8]:
Node
               node_type name  subnetwork_id  source_priority  cyclic_time          geometry
node_id
5        DiscreteControl                <NA>             <NA>        False   POINT Z (1 1 0)
6        DiscreteControl                <NA>             <NA>        False  POINT Z (2 -1 0)

In [9]: m1.write("b/ribasim.toml")
Out[9]: PosixPath('b/ribasim.toml')

In [10]: m2 = ribasim.Model.read("b/ribasim.toml")

In [11]: m2.discrete_control.node.df
Out[11]:
               node_type name  subnetwork_id  source_priority  cyclic_time      geometry
node_id
5        DiscreteControl                <NA>             <NA>        False   POINT (1 1)
6        DiscreteControl                <NA>             <NA>        False  POINT (2 -1)

[visr]

Oh yeah it works for me as well, I think I made a mistake in my snippet...