Skip to content

Implement Junction Node#2175

Merged
evetion merged 14 commits into
mainfrom
feat/junction
Apr 2, 2025
Merged

Implement Junction Node#2175
evetion merged 14 commits into
mainfrom
feat/junction

Conversation

@evetion

@evetion evetion commented Mar 27, 2025

Copy link
Copy Markdown
Member

Fixes #1609

  • Implement tests

@evetion evetion requested review from SouthEndMusic and visr March 27, 2025 10:46
Comment thread core/src/graph.jl Outdated
Comment thread core/src/graph.jl Outdated
Comment thread core/src/validation.jl Outdated
Comment thread core/src/parameter.jl Outdated
@evetion

evetion commented Mar 28, 2025

Copy link
Copy Markdown
Member Author

I've added two testmodels and tests, and improved the testmodel documentation page (text is now Quarto based with index instead of in the plots).

@SouthEndMusic SouthEndMusic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, I left some refactoring suggestions.

Comment thread core/src/graph.jl Outdated
Comment thread core/src/graph.jl
Comment thread core/src/read.jl Outdated
Comment thread core/src/write.jl Outdated
Comment thread docs/reference/node/junction.qmd Outdated
Comment thread python/ribasim_testmodels/ribasim_testmodels/allocation.py Outdated
Comment thread docs/_quarto.yml
Comment thread python/ribasim/ribasim/validation.py

@SouthEndMusic SouthEndMusic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few nits

Comment thread core/src/graph.jl Outdated
Comment thread core/src/read.jl Outdated
Comment thread core/src/read.jl Outdated
Comment thread core/src/write.jl
@evetion evetion merged commit d77f172 into main Apr 2, 2025
@evetion evetion deleted the feat/junction branch April 2, 2025 18:11
@visr visr mentioned this pull request Apr 14, 2025
visr added a commit that referenced this pull request Apr 15, 2025
## [v2025.3.0] - 2025-04-14

The only breaking change in this release is to disallow connecting a
single FlowBoundary to multiple Basins.
There are large improvements in the ability to visualize results on the
map in QGIS.
We also welcome the Junction node to the family, which will help laying
out networks in a recognizable manner.

### Added
- Add spatio-temporal results layers to QGIS.
[#2208](#2208)
- Add topological (straight line) link view toggle to QGIS.
[#2208](#2208)
- Added [Junction](https://ribasim.org/reference/node/junction.html)
node type. [#2175](#2175)
- Write results and log bottlenecks also on an interrupt or crash.
[#2191](#2191)
[#2200](#2200)
- Log computation time and save it to `solver_stats.arrow`.
[#2209](https://github.com/Deltares/Ribasim/pull/)
- Experimental support for writing the model network and results into
files used by Delft-FEWS,
[`model.to_fews`](`https://ribasim.org/reference/python/Model.html#ribasim.Model.to_fews`).
[#2161](#2161)
- Document
[`results/concentration.arrow`](https://ribasim.org/reference/usage.html#concentration---concentration.arrow).
[#2165](#2165)

### Changed
- Allow max 1 outflow neighbour for FlowBoundary.
[#2192](#2192)
- Automatic differentiation is enabled by default again, `autodiff =
true`, leading to better performance.
[#2137](#2137)
[#2183](#2183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Junction node

3 participants