Skip to content

Use autodiff = True as the default again - #2183

Merged
visr merged 3 commits into
mainfrom
autodiffon
Mar 28, 2025
Merged

Use autodiff = True as the default again#2183
visr merged 3 commits into
mainfrom
autodiffon

Conversation

@visr

@visr visr commented Mar 28, 2025

Copy link
Copy Markdown
Member

After #2134 I wanted to check if #1834 was fixed, and it was, so this essentially reverts #1832.

Making it the default since it is noticably faster and should be more accurate as well. I've seen it do better with convergence bottlenecks as well.

# hws_2025_3_0
# autodiff=false
# 57.718218 seconds (15.07 M allocations: 10.536 GiB, 2.00% gc time, 2 lock conflicts)
# autodiff=true
# 51.234467 seconds (14.27 M allocations: 10.210 GiB, 1.76% gc time, 2 lock conflicts)

# AmstelGooienVecht_parameterized_2025_3_4
# autodiff=false
# 7.283102 seconds (2.52 M allocations: 1.033 GiB, 2.59% gc time, 6 lock conflicts)
# autodiff=true
# 5.603329 seconds (951.18 k allocations: 847.611 MiB, 2.76% gc time, 5 lock conflicts)

@visr
visr merged commit 10ff194 into main Mar 28, 2025
@visr
visr deleted the autodiffon branch March 28, 2025 10:16
@visr visr mentioned this pull request Apr 14, 2025
visr added a commit that referenced this pull request Apr 15, 2025
## [v2025.3.0] - 2025-04-14

The only breaking change in this release is to disallow connecting a
single FlowBoundary to multiple Basins.
There are large improvements in the ability to visualize results on the
map in QGIS.
We also welcome the Junction node to the family, which will help laying
out networks in a recognizable manner.

### Added
- Add spatio-temporal results layers to QGIS.
[#2208](#2208)
- Add topological (straight line) link view toggle to QGIS.
[#2208](#2208)
- Added [Junction](https://ribasim.org/reference/node/junction.html)
node type. [#2175](#2175)
- Write results and log bottlenecks also on an interrupt or crash.
[#2191](#2191)
[#2200](#2200)
- Log computation time and save it to `solver_stats.arrow`.
[#2209](https://github.com/Deltares/Ribasim/pull/)
- Experimental support for writing the model network and results into
files used by Delft-FEWS,
[`model.to_fews`](`https://ribasim.org/reference/python/Model.html#ribasim.Model.to_fews`).
[#2161](#2161)
- Document
[`results/concentration.arrow`](https://ribasim.org/reference/usage.html#concentration---concentration.arrow).
[#2165](#2165)

### Changed
- Allow max 1 outflow neighbour for FlowBoundary.
[#2192](#2192)
- Automatic differentiation is enabled by default again, `autodiff =
true`, leading to better performance.
[#2137](#2137)
[#2183](#2183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant