Repository navigation
Allocation renewal - #2266
Allocation renewal#2266
Conversation
jarsarasty
left a comment
There was a problem hiding this comment.
Hi @SouthEndMusic,
I see good progress with the new implementation. For now, I only have minor comments about the way the bounds are handled in the model.
… update parameter handling and enhance error checking for network connections.
|
Here's a status update for the new allocation implementation:
|
|
@jarsarasty here are some updates Because I have done quite some refactoring for Ribasim NL issues this branch accumulated quite some merge conflicts. I therefore decided to bring this branch up to date and merge it soon. I marked the remaining tests that are not green yet as broken, and allocation will be categorized as a experimental feature. This is technically breaking, but allocation is hardly used by modelers. I'm also in conversation about my migration to the wflow team, I will have a meeting about that next Tuesday. It probably means that I have to hand over the allocation developments to @simulutions (Lex) in the coming weeks |
|
Thanks for the updates, @SouthEndMusic! I'll review the changes next week. |
Not yet the release branch, just want to get this out of the way already. Note that this already mentions #2266, we could take that out if needed.
Not yet the release branch, just want to get this out of the way already. Note that this already mentions #2266, we could take that out if needed.
Fixes #2255
Fixes #2149
Fixes #2147