BMI: return 1 on update if solve not successful - #2341
Merged
Merged
Conversation
evetion
approved these changes
Jun 4, 2025
evetion
left a comment
evetion
left a comment
Member
There was a problem hiding this comment.
It's a bit ugly that the macro returns in failures, but you have to pass success yourself. Can't you add return update_retcode(model) to the macro as well?
Member
Author
|
Yeah I agree, but I think this method should only be used for two BMI functions. Otherwise I need a different macro for those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the return code of update and update_until to only return 0 if the solve was successful.
@HendrikKok does this seem ok to you? Or should other methods be changed as well? For other methods like
get_current_timeit is a bit unclear to me what a failure would mean. I assume that it failed to get the current time, and not that the solve of the last update was unsuccesful.