Remove backtracking, add more caching - #2359
Conversation
|
Unless I messed up something in my benchmarking, it seems that the HWS time profile still looks about the same as #2330 (comment), but the allocation situation has improved, going from ~90% to ~70% in relaxation. The issue with the profiler saying there is GC and dynamic dispatch around the closure remains. Still I would've expected a speedup if this does less iterations. Instead I see a 2x regression that I don't understand. At least a part of that is due to now running with |
|
I've been fiddling around quite a bit in this branch, but in the end:
|
visr
left a comment
There was a problem hiding this comment.
Looks good overall. I still want to run some benchmarks. And probably good to make an issue to look into adding relaxation again in the future?
|
I don't understand what went wrong in CI, I cannot reproduce the failing |
|
Restarting CI fixed one of them, the other timed out. It isn't clear to me why CI takes so much longer on this branch, and why there are spurious failures. That makes me a bit hesitant to merge this as one. Perhaps we should first remove relaxation separately? |
visr
left a comment
There was a problem hiding this comment.
Hmm I see the CI time regression also on main, so this branch doesn't seem responsible for it. Great, then we can merge it at once.
Fixes #2189
Fixes #1778