Skip to content

Expand and test LevelDemand functionality - #2386

Merged
SouthEndMusic merged 52 commits into
mainfrom
level_demand
Jul 29, 2025
Merged

SouthEndMusic merged 52 commits into
mainfrom
level_demand

Conversation

@SouthEndMusic

@SouthEndMusic SouthEndMusic commented Jun 19, 2025 •

Copy link
Copy Markdown
Collaborator

Fixes #2319.
Fixes #2418.

@SouthEndMusic
SouthEndMusic marked this pull request as draft June 19, 2025 08:03
@SouthEndMusic SouthEndMusic changed the title Skip allocation model in regression tests Expand and test LevelDemand functionality Jun 23, 2025
@SouthEndMusic

Copy link
Copy Markdown
Collaborator Author

I updated the Julia Tests workflow so that now when allocation fails, the failing problem together with analysis data is written as an artifact that can be downloaded from Github 👍

@SouthEndMusic

SouthEndMusic commented Jul 22, 2025 •

Copy link
Copy Markdown
Collaborator Author

@visr I can't get the Heisenbug model to fail. Given that we get useful artifacts when it does fail, are you fine with keeping these tests active?

Edit: it failed on windows 🙏

@jarsarasty

jarsarasty commented Jul 22, 2025 •

Copy link
Copy Markdown
Collaborator

Hi @SouthEndMusic

The problem is actually feasible when solving it with CPLEX. This is the log from the NEOS server:

MIP - Integer optimal solution:  Objective =  0.0000000000e+00
Solution time =    0.01 sec.  Iterations = 46  Nodes = 0
Deterministic time = 1.93 ticks  (176.04 ticks/sec)

So the issue is happening in the HiGHS solver. We should create a minimal reproducible example to report the issue to the HiGHS developers. In the meantime the test can be temporarily disabled until the issue is resolved upstream.

Update: My comment is only valid if the LP file you shared is from the original problem (without the relaxation).

@verheem verheem left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, big one though. Lets have a discussion tomorrow about how everything is implemented. The code thouches a lot of aspects I can learn about

Comment thread core/src/allocation_init.jl Outdated
Comment thread core/src/allocation_optim.jl
Comment thread core/src/allocation_util.jl Outdated
Comment thread core/src/allocation_util.jl
@SouthEndMusic
SouthEndMusic marked this pull request as ready for review July 28, 2025 07:20
@SouthEndMusic
SouthEndMusic merged commit cbe2a9a into main Jul 29, 2025
@SouthEndMusic
SouthEndMusic deleted the level_demand branch July 29, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rethink goal formulation LevelDemand in allocation

3 participants