Conversation
verheem
marked this pull request as ready for review
September 8, 2025 11:28
Member
|
Perhaps as a way of documentation we should copy-paste the new Since we don't really have a better place to document the CLI at the moment. Great to have this feature! |
visr
approved these changes
Sep 8, 2025
visr
added a commit
that referenced
this pull request
Sep 9, 2025
visr
added a commit
that referenced
this pull request
Sep 9, 2025
I should've triggered the CLI tests manually on #2562. It failed with ``` thread 'main' panicked at src/main.rs:50:55: called `Option::unwrap()` on a `None` value note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` The problem was that when neither `--threads` nor `JULIA_NUM_THREADS` was set, it tried to unwrap `cli.threads` which was none. This avoids that case and adds some tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.