Repository navigation
Conversation
Closed
visr
marked this pull request as ready for review
October 6, 2025 07:57
evetion
reviewed
Oct 6, 2025
evetion
left a comment
evetion
left a comment
Member
There was a problem hiding this comment.
I feel that 99% of the code here could be upstreamed to a table interface implementation on NCDatasets. Without significant tests, I'm hesitant to merge this, especially given the inner/outer repeats that are prone to bugs.
| end | ||
|
|
||
| @testitem "netcdf input" begin | ||
| # TODO use NCDatasets.ncgen to create Delft-FEWS flavored NetCDF input files |
Co-authored-by: Maarten Pronk <git@evetion.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This extends NetCDF reading support (#2434), specifically the
demand_prioritydimension, so these tables:This PR contains some more refactoring of our NetCDF reading code to be able to handle files written by Delft-FEWS. This means e.g. recognizing coordinates by their cf_role or standard_name first, rather than only the variable name. For instance FEWS wouldn't write node_id, but stations with cf_role = timeseries_id.
This still needs more testing, but since I cannot do that now, I made #2617 and propose we add these later.