Repository navigation
Conversation
ribasim script and run_ribasim(toml_path) functionrun_ribasim(toml_path) function
verheem
left a comment
There was a problem hiding this comment.
Nice feature, well commented and tested so no comments 👍
evetion
left a comment
There was a problem hiding this comment.
I appreciate the effort in getting the different shells to work, but it's a lot of untested code.
I'm sad to see the auto downloader go, do we need some documentation on how users can download Ribasim and edit their PATH?
True. This uses mocking to at least exercises the code paths. Other than that I manually tested this on all the shells, which comes down to running Regarding the PATH documentation we already have this: https://ribasim.org/install.html#adding-ribasim-to-path-on-windows |
This adds a script entrypoint to the pyproject.toml that forwards to the ribasim.exe core, but adding automatic installation:
It is stored in a cache dir that will be reused. It first looks on the path if it can find a compatible ribasim.exe
This feature can be used from Python as
run_ribasim, likerun_delwaq.EDIT: the script entrypoint and automatic downloading is now taken out, see #2662. Now we have: