Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use xugrid regridding in generic mesh model setup methods #420

Closed
alimeshgi opened this issue Jun 21, 2023 · 0 comments · Fixed by #535
Closed

Use xugrid regridding in generic mesh model setup methods #420

alimeshgi opened this issue Jun 21, 2023 · 0 comments · Fixed by #535
Assignees
@hboisgon
Labels
Enhancement New feature or request Model issues related to the Model class and its subclasses
Milestone
2023 - Q4

Comments

@alimeshgi
Copy link
Contributor

alimeshgi commented Jun 21, 2023 •
edited by hboisgon

Kind of request

Updating existing functionality

Enhancement Description

In the generic methods of mesh model (setup_mesh2d_from_rasterdataset and setup_mesh2d_from_raster_reclass), update regridding with xugrid functions instead of geopandas and zonal stats.
@alimeshgi alimeshgi added Enhancement New feature or request Model issues related to the Model class and its subclasses Needs refinement issue still needs refinement labels Jun 21, 2023
@alimeshgi alimeshgi added this to the Q3 milestone Jun 21, 2023
@hboisgon hboisgon changed the title Adding generic mesh model setup method Use xugrid regridding in generic mesh model setup methods Sep 21, 2023
@hboisgon hboisgon modified the milestones: Q3, Q4 Sep 21, 2023
@hboisgon hboisgon removed the Needs refinement issue still needs refinement label Sep 21, 2023
hboisgon added a commit that referenced this issue Sep 29, 2023
@hboisgon
use xugrid in mesh methods #420
163dee6
@hboisgon hboisgon mentioned this issue Sep 29, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hboisgon hboisgon

Labels
Enhancement New feature or request Model issues related to the Model class and its subclasses
Projects
None yet
Milestone
2023 - Q4
Development

Successfully merging a pull request may close this issue.

use xugrid in mesh methods Deltares/hydromt
2 participants
@hboisgon @alimeshgi