From 44b91911ae0c52fa2669134b2136947c47990245 Mon Sep 17 00:00:00 2001 From: Panos Athanasiou Date: Wed, 15 May 2024 17:05:34 +0200 Subject: [PATCH] fixed bug where additional attributes appeared double when updating the model --- hydromt_fiat/api/hydromt_fiat_vm.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hydromt_fiat/api/hydromt_fiat_vm.py b/hydromt_fiat/api/hydromt_fiat_vm.py index d48cbebe..267f9667 100644 --- a/hydromt_fiat/api/hydromt_fiat_vm.py +++ b/hydromt_fiat/api/hydromt_fiat_vm.py @@ -222,6 +222,14 @@ def new_additional_attributes(self, config_yaml): aggregation_area_fn = config_yaml.model_extra["setup_additional_attributes"].aggregation_area_fn attribute_names = config_yaml.model_extra["setup_additional_attributes"].attribute_names label_names = config_yaml.model_extra["setup_additional_attributes"].label_names + # Check if additional attributes already exist + add_attrs_existing = [attr["name"] for attr in self.fiat_model.spatial_joins["additional_attributes"]] + for i, label_name in enumerate(label_names): + if label_name in add_attrs_existing: # if it exists exclude it from the list + aggregation_area_fn.pop(i) + attribute_names.pop(i) + label_names.pop(i) + self.fiat_model.setup_additional_attributes(aggregation_area_fn, attribute_names, label_names) def new_ground_elevation(self, config_yaml):