{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":632545198,"defaultBranch":"main","name":"sanoid","ownerLogin":"Deltik","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-25T16:18:28.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1364268?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1718241027.0","currentOid":""},"activityList":{"items":[{"before":"8a023d6d7bacb78959e4a5dcab0a1cbf68e84d69","after":"191ddfe600a2df9819e5c3db589ec9f95134ff79","ref":"refs/heads/hotfix/regression/getsnaps","pushedAt":"2024-06-15T03:55:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"perf(syncoid): Regression: Bad performance due to `zfs get all`\n\nReturn to using `zfs get guid,creation,createtxg` to avoid the\nperformance overhead of `zfs get all`.\n\nThere is a per-host global cache to remember:\n* if `zfs get` supports the type filter argument, `-t snapshot` and\n* which ZFS properties are available.\n\nThe feature check introduced by subroutine `check_zfs_get_features`\neliminates the need for a `getsnaps` fallback recursion, as there is no\nlonger any guesswork into what features `zfs get` supports.\n\nFixes:\nhttps://github.com/jimsalterjrs/sanoid/pull/818#issuecomment-2157567968","shortMessageHtmlLink":"perf(syncoid): Regression: Bad performance due to <code>zfs get all</code>"}},{"before":null,"after":"8a023d6d7bacb78959e4a5dcab0a1cbf68e84d69","ref":"refs/heads/hotfix/regression/getsnaps","pushedAt":"2024-06-13T01:10:27.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"perf(syncoid): Regression: Bad performance due to `zfs get all`\n\nReturn to using `zfs get guid,creation,createtxg` to avoid the\nperformance overhead of `zfs get all`.\n\nThere is a per-host global cache to remember:\n* if `zfs get` supports the type filter argument, `-t snapshot` and\n* which ZFS properties are available.\n\nThe feature check introduced by subroutine `check_zfs_get_features`\neliminates the need for a `getsnaps` fallback recursion, as there is no\nlonger any guesswork into what features `zfs get` supports.\n\nFixes:\nhttps://github.com/jimsalterjrs/sanoid/pull/818#issuecomment-2157567968","shortMessageHtmlLink":"perf(syncoid): Regression: Bad performance due to <code>zfs get all</code>"}},{"before":"a625b9ce76e0b531cc8c2cadf423f405b3237137","after":"fab4b4076cb10b4f4722e827e0fad3d940fc4a5b","ref":"refs/heads/fix/918","pushedAt":"2024-04-26T07:18:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"fix(syncoid): `zfs send` arg allowlist when sendsource is receivetoken\n\nThe `runsynccmd` subroutine was not matching the `$sendsource` when a\nreceive resume token is passed in. All usages that pass in the receive\nresume token do not begin with a space; instead, they start with `-t `.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/918","shortMessageHtmlLink":"fix(syncoid): <code>zfs send</code> arg allowlist when sendsource is receivetoken"}},{"before":"c5fed7c07ab434b3514879f783af001d56b12faa","after":"a625b9ce76e0b531cc8c2cadf423f405b3237137","ref":"refs/heads/fix/918","pushedAt":"2024-04-24T18:16:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"fix(syncoid): `zfs send` arg allowlist when sendsource is receivetoken\n\nThe `runsynccmd` subroutine was not matching the `$sendsource` when a\nreceive resume token is passed in. All usages that pass in the receive\nresume token do not begin with a space; instead, they start with `-t `.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/918","shortMessageHtmlLink":"fix(syncoid): <code>zfs send</code> arg allowlist when sendsource is receivetoken"}},{"before":"afc2d7d5b1c04f456662d701c6031fa1971916d0","after":"c5fed7c07ab434b3514879f783af001d56b12faa","ref":"refs/heads/fix/918","pushedAt":"2024-04-24T18:12:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"fix(syncoid): `zfs send` arg allowlist when sendsource is receivetoken\n\nThe `runsynccmd` subroutine was not matching the `$sendsource` when a\nreceive resume token is passed in. All usages that pass in the receive\nresume token do not begin with a space; instead, they start with `-t `.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/918","shortMessageHtmlLink":"fix(syncoid): <code>zfs send</code> arg allowlist when sendsource is receivetoken"}},{"before":"e9ad83a6e6cb09aec8c6dc0f6dc607c82922e94c","after":"afc2d7d5b1c04f456662d701c6031fa1971916d0","ref":"refs/heads/fix/918","pushedAt":"2024-04-24T18:10:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"fix(syncoid): `zfs send` arg allowlist when sendsource is receivetoken\n\nThe `runsynccmd` subroutine was not matching the `$sendsource` when a\nreceive resume token is passed in. All usages that pass in the receive\nresume token do not begin with a space; instead, they start with `-t `.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/918","shortMessageHtmlLink":"fix(syncoid): <code>zfs send</code> arg allowlist when sendsource is receivetoken"}},{"before":null,"after":"e9ad83a6e6cb09aec8c6dc0f6dc607c82922e94c","ref":"refs/heads/fix/918","pushedAt":"2024-04-24T18:08:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"fix(syncoid): `zfs send` arg allowlist when sendsource is receivetoken\n\nThe `runsynccmd` subroutine was not matching the `$sendsource` when a\nreceive resume token is passed in. All usages that pass in the receive\nresume token do not begin with a space; instead, they start with `-t `.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/918","shortMessageHtmlLink":"fix(syncoid): <code>zfs send</code> arg allowlist when sendsource is receivetoken"}},{"before":"a904ba02f3158b971786f2e864fabe5227075cc8","after":null,"ref":"refs/heads/fix/815","pushedAt":"2024-02-01T19:31:01.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"}},{"before":"85d7cc1c27bb1bc14b5bd55197382c6a21bf240a","after":"a904ba02f3158b971786f2e864fabe5227075cc8","ref":"refs/heads/fix/815","pushedAt":"2024-01-30T13:09:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"0571701f90c9603da7d6852a7a857c7a091b1075","after":"85d7cc1c27bb1bc14b5bd55197382c6a21bf240a","ref":"refs/heads/fix/815","pushedAt":"2024-01-30T12:47:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"6b3f8683bff16d242def81ad55b8a8051ff6acdc","after":"0571701f90c9603da7d6852a7a857c7a091b1075","ref":"refs/heads/fix/815","pushedAt":"2024-01-29T23:21:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"d6b37a9106f22c7978c1e8bd938ea09a523364a3","after":"6b3f8683bff16d242def81ad55b8a8051ff6acdc","ref":"refs/heads/fix/815","pushedAt":"2023-07-25T13:30:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"602fd72f333f9a8c8bc8ae4c6a953e73492897fc","after":"d6b37a9106f22c7978c1e8bd938ea09a523364a3","ref":"refs/heads/fix/815","pushedAt":"2023-05-01T05:12:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"7c7f1a0bd4d5873edd00a8eeaf5536894ea273ae","after":"602fd72f333f9a8c8bc8ae4c6a953e73492897fc","ref":"refs/heads/fix/815","pushedAt":"2023-04-28T06:07:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"4f929db0980a85189f051fb6be4c225d2acce801","after":"7c7f1a0bd4d5873edd00a8eeaf5536894ea273ae","ref":"refs/heads/fix/815","pushedAt":"2023-04-28T06:06:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"bf3a791cb2bde2984af03b30f72b25d4e074d524","after":"4f929db0980a85189f051fb6be4c225d2acce801","ref":"refs/heads/fix/815","pushedAt":"2023-04-28T06:00:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"enh(run-tests.sh): Sort tests with \"general numeric sort\"\n\nThe sort before tended to be alphabetical, which put test\n`8_force_delete_snapshot` after `815_sync_out-of-order_snapshots`, but\n`8` should come before `815`.\n\nBefore:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0x90000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\n```\n\nAfter:\n\n```\nroot@demo:~/sanoid/tests/syncoid# ./run-tests.sh\nRunning test 1_bookmark_replication_intermediate ... [PASS]\nRunning test 2_bookmark_replication_no_intermediate ... [PASS]\nRunning test 3_force_delete ... [PASS]\nRunning test 4_bookmark_replication_edge_case ... [PASS]\nRunning test 5_reset_resume_state ... mbuffer: error: outputThread: error writing to <stdout> at offset 0xf0000: Broken pipe\nmbuffer: warning: error during output to <stdout>: Broken pipe\n[PASS]\nRunning test 6_reset_resume_state2 ... [PASS]\nRunning test 7_preserve_recordsize ... [PASS]\nRunning test 8_force_delete_snapshot ... [PASS]\nRunning test 815_sync_out-of-order_snapshots ... [PASS]\n```","shortMessageHtmlLink":"enh(run-tests.sh): Sort tests with \"general numeric sort\""}},{"before":"8c205bcd22ab346b51c7519de44c879e4b492d98","after":"bf3a791cb2bde2984af03b30f72b25d4e074d524","ref":"refs/heads/fix/815","pushedAt":"2023-04-28T05:45:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"1075ca722f73539d3d54b270d98f1ba916cfd5c9","after":"8c205bcd22ab346b51c7519de44c879e4b492d98","ref":"refs/heads/fix/815","pushedAt":"2023-04-28T05:37:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"df4682e14562c1ae65f0ccb4823296e4882655e9","after":"1075ca722f73539d3d54b270d98f1ba916cfd5c9","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T22:59:43.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"962b0759c04b8ac1fd32bd716f1096b544c18395","after":"df4682e14562c1ae65f0ccb4823296e4882655e9","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T22:55:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"68b52b9291bb420d0f29d071fa5ec6bbc4a7e910","after":"962b0759c04b8ac1fd32bd716f1096b544c18395","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T22:37:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"4a52a0f0bd6081e27c8ab10b599ba7714f9a9e10","after":"68b52b9291bb420d0f29d071fa5ec6bbc4a7e910","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T22:35:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"test(syncoid): Add test to verify out-of-order snapshot sync\n\nSee https://github.com/jimsalterjrs/sanoid/issues/815 for the original\ntest.","shortMessageHtmlLink":"test(syncoid): Add test to verify out-of-order snapshot sync"}},{"before":"54057df25f92410a1912dca78dcdd5f822da8244","after":"4a52a0f0bd6081e27c8ab10b599ba7714f9a9e10","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T22:07:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Match snapshots to bookmarks by `createtxg` if possible\n\nThis is a continuation of a previous commit to sort snapshots by\n`createtxg` if possible.  Now, we have to match the behavior when\nselecting an appropriate snapshot based on the transaction group of the\nrelevant bookmark in `syncdataset()`.\n\nSupercedes: https://github.com/jimsalterjrs/sanoid/pull/667","shortMessageHtmlLink":"feat(syncoid): Match snapshots to bookmarks by <code>createtxg</code> if possible"}},{"before":"58355ae51c543452322072364fa89b06c4a1b8b9","after":"54057df25f92410a1912dca78dcdd5f822da8244","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T20:15:19.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Sort snapshots by `createtxg` if possible\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nAlso, `syncoid --no-sync-snap` might not pick up the most recently taken\nsnapshot if the clock moved backwards before taking that snapshot.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots, but it was not\navailable in ZFS versions before 0.7.  To maintain backwards\ncompatibility, the sorting falls back to sorting by the `creation`\nproperty, which was the old behavior.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Sort snapshots by <code>createtxg</code> if possible"}},{"before":"b15dbb22a087164049cd944adefb8c278ba0b3fa","after":"58355ae51c543452322072364fa89b06c4a1b8b9","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T20:02:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Sort snapshots by `createtxg` if possible\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nAlso, `syncoid --no-sync-snap` might not pick up the most recently taken\nsnapshot if the clock moved backwards before taking that snapshot.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots, but it was not\navailable in ZFS versions before 0.7.  To maintain backwards\ncompatibility, the sorting falls back to sorting by the `creation`\nproperty, which was the old behavior.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Sort snapshots by <code>createtxg</code> if possible"}},{"before":"126d92ce31b183befd131d44db2e03cf2a92c8b1","after":"b15dbb22a087164049cd944adefb8c278ba0b3fa","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T19:58:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Sort snapshots by `createtxg` if possible\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nAlso, `syncoid --no-sync-snap` might not pick up the most recently taken\nsnapshot if the clock moved backwards before taking that snapshot.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots, but it was not\navailable in ZFS versions before 0.7.  To maintain backwards\ncompatibility, the sorting falls back to sorting by the `creation`\nproperty, which was the old behavior.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Sort snapshots by <code>createtxg</code> if possible"}},{"before":"2be6866ab5369f526ab483d00b958f7fb456b94f","after":"126d92ce31b183befd131d44db2e03cf2a92c8b1","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T19:54:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Sort snapshots by `createtxg` if possible\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nAlso, `syncoid --no-sync-snap` might not pick up the most recently taken\nsnapshot if the clock moved backwards before taking that snapshot.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots, but it was not\navailable in ZFS versions before 0.7.  To maintain backwards\ncompatibility, the sorting falls back to sorting by the `creation`\nproperty, which was the old behavior.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Sort snapshots by <code>createtxg</code> if possible"}},{"before":"0659699e1ac2cc17883ee3aaaea80b7373fc48d6","after":"2be6866ab5369f526ab483d00b958f7fb456b94f","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T19:04:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Initial sync: `getoldestsnapshot` from createtxg\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots.\n\nThere are no other usages of `getoldestsnapshot()` besides this initial\nsync, so there is practically no regression potential of this change.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Initial sync: <code>getoldestsnapshot</code> from createtxg"}},{"before":"22fb4a750a9e1f34713558b525dc19a216aef62e","after":"0659699e1ac2cc17883ee3aaaea80b7373fc48d6","ref":"refs/heads/fix/815","pushedAt":"2023-04-25T19:02:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"},"commit":{"message":"feat(syncoid): Initial sync: `getoldestsnapshot` from createtxg\n\nIt is possible for `creation` of a subsequent snapshot to be in the past\ncompared to the current snapshot due to system clock discrepancies,\nwhich leads to earlier snapshots not being replicated in the initial\nsyncoid sync.\n\nSorting snapshots by the `createtxg` value is reliable and documented\nin `man 8 zfsprops` as the proper way to order snapshots.\n\nThere are no other usages of `getoldestsnapshot()` besides this initial\nsync, so there is practically no regression potential of this change.\n\nFixes: https://github.com/jimsalterjrs/sanoid/issues/815","shortMessageHtmlLink":"feat(syncoid): Initial sync: <code>getoldestsnapshot</code> from createtxg"}},{"before":"86fffca306ecd0e5bdb7eb413f4970024f96b53f","after":null,"ref":"refs/heads/master","pushedAt":"2023-04-25T16:32:17.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Deltik","name":"Nick L.","path":"/Deltik","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1364268?s=80&v=4"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEZf6pYAA","startCursor":null,"endCursor":null}},"title":"Activity · Deltik/sanoid"}