From a14709b0cd342d35e9f12b27c94b0ba73f02e0b8 Mon Sep 17 00:00:00 2001
From: DemchaAV <demchaav@gmail.com>
Date: Mon, 1 Jun 2026 11:04:52 +0100
Subject: [PATCH] build: narrow flexmark-all to targeted modules +
 jcl-over-slf4j bridge (F3)

GraphCompose's only flexmark consumer is `MarkDownParser`, which
references the core parser + AST, `util.ast.Node`/`NodeVisitor`/
`VisitHandler`, and `util.data.MutableDataSet`. The full
`flexmark-all` aggregator pulled ~40 jars of extensions, formatters,
and converters that the codebase never touches.

- Replace `flexmark-all` with the three modules actually used:
  `flexmark` (core), `flexmark-util-ast`, `flexmark-util-data`.
- Add `jcl-over-slf4j` as an explicit compile dep. PDFBox 3.0.7's
  `PDDocument.<clinit>` still calls `org.apache.commons.logging.
  LogFactory` directly; we exclude PDFBox's own commons-logging to
  keep a single logging facade, but the bridge was previously
  provided transitively via `flexmark-all`. Without it the
  classpath now misses LogFactory and every PDDocument-touching
  test fails with `NoClassDefFoundError` at clinit. The bridge
  routes those calls through SLF4J, which is the library's chosen
  logging facade.

Consumer impact: callers that depended on flexmark extensions
(`flexmark-ext-tables`, gfm-strikethrough, footnotes, etc.) flowing
through GraphCompose must declare those modules explicitly.

Gates: 1031 tests pass; dependency:tree no longer lists
`flexmark-all`; japicmp vs v1.6.6 reports semver OK.
---
 CHANGELOG.md | 15 +++++++++++++++
 pom.xml      | 37 ++++++++++++++++++++++++++++++++++++-
 2 files changed, 51 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fdec1a58..38cbc6d3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,6 +19,21 @@ planned; the next minor with new canonical DSL primitives is
   the Kotlin standard library transitively. Consumers that
   relied on `kotlin-stdlib` flowing through GraphCompose must
   declare it explicitly.
+- Replaced the `flexmark-all` aggregator dependency with the three
+  modules actually referenced by `MarkDownParser`: `flexmark`
+  (core parser + AST), `flexmark-util-ast` (Node / NodeVisitor /
+  VisitHandler), and `flexmark-util-data` (MutableDataSet). No
+  extension modules (tables, footnotes, gfm-strikethrough, etc.)
+  are used by GraphCompose. Consumers that relied on extensions
+  flowing through GraphCompose must depend on the relevant
+  `flexmark-ext-*` modules explicitly.
+- Added `jcl-over-slf4j` as an explicit compile dependency. PDFBox
+  3.0.7's `PDDocument.<clinit>` calls `org.apache.commons.logging.
+  LogFactory` directly; we exclude PDFBox's own `commons-logging`
+  artifact to keep one logging facade, and the bridge routes those
+  calls through SLF4J. Previously the bridge was provided
+  transitively via `flexmark-all`; making it explicit keeps the
+  classpath reproducible after the flexmark narrowing above.
 
 ### Internal
 
diff --git a/pom.xml b/pom.xml
index 25f9af0b..db3ea72c 100644
--- a/pom.xml
+++ b/pom.xml
@@ -122,6 +122,21 @@
             <artifactId>slf4j-api</artifactId>
             <version>${slf4j.version}</version>
         </dependency>
+        <!--
+            commons-logging → SLF4J bridge. PDFBox's static initializer
+            (`PDDocument.<clinit>`) still calls `org.apache.commons.logging.
+            LogFactory` directly. We exclude PDFBox's own `commons-logging`
+            artefact to keep a single logging facade and route those calls
+            through SLF4J via this drop-in replacement. Previously this
+            class was on the classpath transitively via `flexmark-all` —
+            F3 (v1.6.7) narrowed flexmark to its core modules and made
+            the bridge explicit so the build is reproducible.
+        -->
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>jcl-over-slf4j</artifactId>
+            <version>${slf4j.version}</version>
+        </dependency>
 
         <dependency>
             <groupId>org.apache.pdfbox</groupId>
@@ -135,9 +150,29 @@
             </exclusions>
         </dependency>
 
+        <!--
+            Flexmark markdown parser. F3 (v1.6.7) narrowed `flexmark-all`
+            down to the modules actually referenced by
+            `com.demcha.compose.engine.text.markdown.MarkDownParser`:
+            - `flexmark`           — Parser + `com.vladsch.flexmark.ast.*`
+                                     (Heading, ListItem, Emphasis, etc.)
+            - `flexmark-util-ast`  — Node, NodeVisitor, VisitHandler
+            - `flexmark-util-data` — MutableDataSet
+            No extension modules (tables, footnotes, gfm) are used.
+        -->
+        <dependency>
+            <groupId>com.vladsch.flexmark</groupId>
+            <artifactId>flexmark</artifactId>
+            <version>${flexmark.version}</version>
+        </dependency>
+        <dependency>
+            <groupId>com.vladsch.flexmark</groupId>
+            <artifactId>flexmark-util-ast</artifactId>
+            <version>${flexmark.version}</version>
+        </dependency>
         <dependency>
             <groupId>com.vladsch.flexmark</groupId>
-            <artifactId>flexmark-all</artifactId>
+            <artifactId>flexmark-util-data</artifactId>
             <version>${flexmark.version}</version>
         </dependency>