Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eviction Refactoring #41

Merged
merged 6 commits into from Jun 7, 2012
Merged

Eviction Refactoring #41

merged 6 commits into from Jun 7, 2012

Conversation

catalincapota
Copy link
Collaborator

Refactored the eviction code to no longer call on every single message please see issue #22.

Modified eviction logic to perform better overall.

@catalincapota
Copy link
Collaborator Author

@sheetalparade , @jimfcarroll Please review the attached changes.

I incorporated the following suggestions and resolved some existing bugs in the codebase.

  1. Added eviction frequency instead of just milliseconds and also added TimeUnit to eviction schedule
  2. Added Eviction Pass Started, Duration to Stats Collectors
  3. Removed Unused Output Scheduler from MpContainer, (should have been removed with cronoutput schedule changes #40 or Resolved the testOutPutMessage() issue #34)
  4. Added missing Eviction check during output scheduler routine
  5. Modified order of Eviction Routine
  6. Fixed improper stats calculation in BasicStatsCollector that used preInstantiationStart instead of outputInvoke start to calculate output duration.

jimfcarroll pushed a commit that referenced this pull request Jun 7, 2012
@jimfcarroll jimfcarroll merged commit 70bf4e8 into Dempsy:master Jun 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants