Improve compatibility, and fix some bugs #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvenient for test on Github Actions
…inking on Windows
Owner
Author
|
use |
Dengda98
added a commit
that referenced
this pull request
Apr 20, 2025
Improve compatibility, and fix some bugs
Dengda98
added a commit
that referenced
this pull request
Apr 21, 2025
Improve compatibility, and fix some bugs
Dengda98
added a commit
that referenced
this pull request
Apr 21, 2025
Improve compatibility, and fix some bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance compatibility with macOS and Windows by updating the Makefile and some functions.
Some bugs are fixed before this branch:
Fix print bug of
grtwith long-length array, which has array index out of bound, may cause segmentation fault.mkdirfunction on Windows (mkdir under mingw #1 )Stack Overflow. (The multichannel example can't run. #2 ). (epsecially in multi-threads)
In early version
ptam.c, I set some variable-length array (variablenr), which needs some stack memory. Since Windows set lower stack size than Ubuntu and MacOS, when you pass too many stations at once, program might broke on Windows.In new version, I allocate the memory from heap (using malloc/calloc), and set
-Wl,-stack_size,0x1000000for Windows.Set
SetConsoleOutputCP(65001);on Windows to show logo normally.