Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for SMAPI 2.0 #41

Merged
merged 6 commits into from Oct 4, 2017
Merged

Update for SMAPI 2.0 #41

merged 6 commits into from Oct 4, 2017

Conversation

Pathoschild
Copy link
Collaborator

This pull request...

  • Fixes compatibility with SMAPI 2.0 (without breaking compatibility with earlier versions).
  • Updates the mod build package to the latest version.
    This adds support for deploying into the mod folder automatically, which I enabled for BuyRecipes. I left SendItems's deploy task as-is due to its config handling.
  • Replaces custom update checks with SMAPI's new update-check feature.
  • Bumps the versions for release.

I branched from master so the updates can be deployed independently of your refactor in develop. If the changes look fine, can you release BuyRecipes 1.0.1.zip and SendItems 1.0.3.zip? (Once this pull request is accepted, I can merge the changes into your develop branch if you want.)

@Denifia
Copy link
Owner

Denifia commented Oct 4, 2017

Out of interest... was this update requested by someone in the community, or you're just updating a bunch anyway?

Copy link
Owner

@Denifia Denifia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, all looks good - thanks for doing this :)

@Pathoschild
Copy link
Collaborator Author

I'm updating a lot of mods as part of the SMAPI 2.0 migration. Some players may have requested the update, but unfortunately I don't keep track beyond making sure the requested mods are on that list.

@Pathoschild
Copy link
Collaborator Author

Pathoschild commented Oct 4, 2017

Thanks for the code review! You sent me an invite to the repo; did you want me to merge this pull request?

@Denifia
Copy link
Owner

Denifia commented Oct 4, 2017

I'm not in a position where I can push out a new build for at least a week. Yup, I've given you access so if you'd like to merge and create a new build - feel free :)

Also, this way if in the future you want to make changes so support SMAPI, you can just jump in a do it :P

@Pathoschild
Copy link
Collaborator Author

Will do!

If you add me as a team member on the Nexus mod pages, I can release the updates too. Here's how if you're interested:

  1. Open the mod pages (see Buy Cooking Recipes and Send Items).
  2. Click edit attributes in the sidebar.
  3. Add Pathoschild under Other team members and click the (+) button next to the field.
  4. Click submit at the bottom.

@Denifia
Copy link
Owner

Denifia commented Oct 4, 2017

Coolies... I've added you to both projects on Nexus mods. Feel free to update the mods, release new versions, etc.

@Pathoschild Pathoschild merged commit 923ef68 into Denifia:master Oct 4, 2017
@Pathoschild Pathoschild deleted the update-code branch October 4, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants