New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for SMAPI 2.0 #41
Conversation
Out of interest... was this update requested by someone in the community, or you're just updating a bunch anyway? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, all looks good - thanks for doing this :)
I'm updating a lot of mods as part of the SMAPI 2.0 migration. Some players may have requested the update, but unfortunately I don't keep track beyond making sure the requested mods are on that list. |
Thanks for the code review! You sent me an invite to the repo; did you want me to merge this pull request? |
I'm not in a position where I can push out a new build for at least a week. Yup, I've given you access so if you'd like to merge and create a new build - feel free :) Also, this way if in the future you want to make changes so support SMAPI, you can just jump in a do it :P |
Will do! If you add me as a team member on the Nexus mod pages, I can release the updates too. Here's how if you're interested:
|
Coolies... I've added you to both projects on Nexus mods. Feel free to update the mods, release new versions, etc. |
This pull request...
This adds support for deploying into the mod folder automatically, which I enabled for BuyRecipes. I left SendItems's deploy task as-is due to its config handling.
I branched from
master
so the updates can be deployed independently of your refactor indevelop
. If the changes look fine, can you release BuyRecipes 1.0.1.zip and SendItems 1.0.3.zip? (Once this pull request is accepted, I can merge the changes into yourdevelop
branch if you want.)