From fbf6fb7ed784c74546f62cd1cfdfe4272b57ccb7 Mon Sep 17 00:00:00 2001
From: mcmonkey <agoodwin@freneticllc.com>
Date: Tue, 20 Nov 2018 18:46:28 -0800
Subject: [PATCH] repatch that

---
 .../net/aufdemrand/denizencore/scripts/ScriptEntry.java   | 8 --------
 .../denizencore/scripts/commands/BracedCommand.java       | 2 +-
 .../denizencore/scripts/commands/CommandExecuter.java     | 8 ++++++--
 .../denizencore/scripts/commands/core/IfCommand.java      | 2 +-
 4 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/main/java/net/aufdemrand/denizencore/scripts/ScriptEntry.java b/src/main/java/net/aufdemrand/denizencore/scripts/ScriptEntry.java
index 4eb11753..e821c14d 100644
--- a/src/main/java/net/aufdemrand/denizencore/scripts/ScriptEntry.java
+++ b/src/main/java/net/aufdemrand/denizencore/scripts/ScriptEntry.java
@@ -360,14 +360,6 @@ public ScriptEntry defaultObject(String key, Object... objects) throws InvalidAr
         }
     }
 
-    public List<String> getProperArguments() {
-        List<String> args_temp = new ArrayList<>();
-        for (Argument arg : args_cur) {
-            args_temp.add(arg.aHArg.toString());
-        }
-        return args_temp;
-    }
-
     public List<String> getArguments() {
         return args;
     }
diff --git a/src/main/java/net/aufdemrand/denizencore/scripts/commands/BracedCommand.java b/src/main/java/net/aufdemrand/denizencore/scripts/commands/BracedCommand.java
index 14f55792..3446bbb3 100644
--- a/src/main/java/net/aufdemrand/denizencore/scripts/commands/BracedCommand.java
+++ b/src/main/java/net/aufdemrand/denizencore/scripts/commands/BracedCommand.java
@@ -68,7 +68,7 @@ public static List<BracedData> getBracedCommands(ScriptEntry scriptEntry) {
                     if (bd.needPatch) {
                         newbd.args = new ArrayList<String>(bd.args.size());
                         for (int x = bd.aStart; x <= bd.aEnd; x++) {
-                            newbd.args.add(scriptEntry.args.get(x));
+                            newbd.args.add(CommandExecuter.parseDefsRaw(scriptEntry, scriptEntry.args.get(x)));
                         }
                         break;
                     }
diff --git a/src/main/java/net/aufdemrand/denizencore/scripts/commands/CommandExecuter.java b/src/main/java/net/aufdemrand/denizencore/scripts/commands/CommandExecuter.java
index f8404e5f..ea59a246 100644
--- a/src/main/java/net/aufdemrand/denizencore/scripts/commands/CommandExecuter.java
+++ b/src/main/java/net/aufdemrand/denizencore/scripts/commands/CommandExecuter.java
@@ -20,7 +20,7 @@ public CommandExecuter() {
     }
 
     public static String parseDefsRaw(ScriptEntry scriptEntry, String arg) {
-        if (arg.indexOf('%') == -1) {
+        if (!hasDef(arg)) {
             return arg;
         }
         Matcher m;
@@ -54,6 +54,10 @@ public static String parseDefsRaw(ScriptEntry scriptEntry, String arg) {
         return sb.toString();
     }
 
+    public static boolean hasDef(String arg) {
+        return arg.indexOf('%') != -1;
+    }
+
     public static boolean handleDefs(ScriptEntry scriptEntry, boolean genned) {
         if (scriptEntry.internal.hasOldDefs) {
             if (!genned) {
@@ -62,7 +66,7 @@ public static boolean handleDefs(ScriptEntry scriptEntry, boolean genned) {
             }
             for (int argId : scriptEntry.internal.processArgs) {
                 String arg = scriptEntry.args.get(argId);
-                if (arg.indexOf('%') != -1) {
+                if (hasDef(arg)) {
                     String parsed = parseDefsRaw(scriptEntry, arg);
                     scriptEntry.setArgument(argId, parsed);
                     aH.Argument aharg = new aH.Argument(parsed);
diff --git a/src/main/java/net/aufdemrand/denizencore/scripts/commands/core/IfCommand.java b/src/main/java/net/aufdemrand/denizencore/scripts/commands/core/IfCommand.java
index 62a31327..6beab935 100644
--- a/src/main/java/net/aufdemrand/denizencore/scripts/commands/core/IfCommand.java
+++ b/src/main/java/net/aufdemrand/denizencore/scripts/commands/core/IfCommand.java
@@ -58,7 +58,7 @@ public void parseArgs(ScriptEntry scriptEntry) throws InvalidArgumentsException
                 elseRef.key = nextEntry.toString();
                 elseRef.args = new ArrayList<>();
                 elseRef.args.add("else");
-                elseRef.args.addAll(nextEntry.getProperArguments());
+                elseRef.args.addAll(nextEntry.getArguments());
                 allData.add(elseRef);
             }
             scriptEntry.addObject("braces", allData);