From 53d449459c95a8d28694d0fe07a1823e0b161f97 Mon Sep 17 00:00:00 2001 From: Morphan1 Date: Thu, 11 Jun 2015 02:09:09 -0400 Subject: [PATCH] Don't create empty lines of lore on random items --- .../utilities/packets/intercept/DenizenPacketListener.java | 7 +++---- .../utilities/packets/intercept/PacketOutHandler.java | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/DenizenPacketListener.java b/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/DenizenPacketListener.java index 28cfadfa8d..14a6685a45 100644 --- a/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/DenizenPacketListener.java +++ b/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/DenizenPacketListener.java @@ -31,13 +31,12 @@ public static void enable() { @Override public void a(PacketPlayInSetCreativeSlot packet) { ItemStack itemStack = packet.getItemStack(); - if (itemStack != null && itemStack.getTag() != null && !itemStack.getTag().isEmpty()) { + if (itemStack != null && itemStack.hasTag() && !itemStack.getTag().isEmpty()) { NBTTagCompound tag = itemStack.getTag(); - String hash = tag.getString("Denizen Item Script"); - if (hash != null) { + if (tag.hasKey("Denizen Item Script")) { NBTTagCompound display = tag.getCompound("display"); NBTTagList nbtLore = display.hasKey("Lore") ? (NBTTagList) display.get("Lore") : new NBTTagList(); - nbtLore.add(new NBTTagString(hash)); + nbtLore.add(new NBTTagString(tag.getString("Denizen Item Script"))); display.set("Lore", nbtLore); tag.set("display", display); itemStack.setTag(tag); diff --git a/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java b/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java index 5d246e9512..43cca43cda 100644 --- a/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java +++ b/src/main/java/net/aufdemrand/denizen/utilities/packets/intercept/PacketOutHandler.java @@ -44,6 +44,7 @@ else if (packet instanceof PacketPlayOutWindowItems) { for (int i = 0; i < itemStacks.length; i++) { itemStacks[i] = removeItemScriptLore(itemStacks[i]); } + window_items_itemStackArray.set(wiPacket, itemStacks); } else if (packet instanceof PacketPlayOutNamedEntitySpawn) { PacketPlayOutNamedEntitySpawn nesPacket = (PacketPlayOutNamedEntitySpawn) packet; @@ -74,7 +75,7 @@ else if (packet instanceof PacketPlayOutPlayerInfo) { } private static ItemStack removeItemScriptLore(ItemStack itemStack) throws Exception{ - if (itemStack != null && itemStack.getTag() != null && !itemStack.getTag().isEmpty()) { + if (itemStack != null && itemStack.hasTag() && !itemStack.getTag().isEmpty()) { NBTTagCompound tag = itemStack.getTag(); NBTTagCompound display = tag.getCompound("display"); NBTTagList lore = (NBTTagList) display.get("Lore");