From 7cd346357b294ac59ca0d9456cf2ea6f7d9dae85 Mon Sep 17 00:00:00 2001 From: "Alex \"mcmonkey\" Goodwin" Date: Fri, 21 Jul 2023 08:52:37 -0700 Subject: [PATCH] deprecation refresh_chunk_sections --- .../java/com/denizenscript/denizen/objects/ChunkTag.java | 6 +++++- .../denizen/utilities/BukkitImplDeprecations.java | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/plugin/src/main/java/com/denizenscript/denizen/objects/ChunkTag.java b/plugin/src/main/java/com/denizenscript/denizen/objects/ChunkTag.java index 9292e14794..7bf4ffa834 100644 --- a/plugin/src/main/java/com/denizenscript/denizen/objects/ChunkTag.java +++ b/plugin/src/main/java/com/denizenscript/denizen/objects/ChunkTag.java @@ -1,6 +1,7 @@ package com.denizenscript.denizen.objects; import com.denizenscript.denizen.nms.NMSVersion; +import com.denizenscript.denizen.utilities.BukkitImplDeprecations; import com.denizenscript.denizencore.utilities.debugging.Debug; import com.denizenscript.denizen.utilities.flags.DataPersistenceFlagTracker; import com.denizenscript.denizen.utilities.flags.LocationFlagSearchHelper; @@ -889,14 +890,17 @@ public void adjust(Mechanism mechanism) { // @object ChunkTag // @name refresh_chunk_sections // @input None + // @deprecated for MC 1.18+, use 'refresh_chunk' // @description // Refreshes all 16x16x16 chunk sections within the chunk. + // For MC 1.18+, prefer <@link mechanism ChunkTag.refresh_chunk> // @example // - adjust refresh_chunk_sections // --> if (mechanism.matches("refresh_chunk_sections")) { if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_18)) { - getBukkitWorld().regenerateChunk(chunkX, chunkZ); + BukkitImplDeprecations.chunkRefreshSections.warn(mechanism.context); + getBukkitWorld().refreshChunk(chunkX, chunkZ); } else { NMSHandler.chunkHelper.refreshChunkSections(getChunk()); diff --git a/plugin/src/main/java/com/denizenscript/denizen/utilities/BukkitImplDeprecations.java b/plugin/src/main/java/com/denizenscript/denizen/utilities/BukkitImplDeprecations.java index 8957cba3f3..a19cb39462 100644 --- a/plugin/src/main/java/com/denizenscript/denizen/utilities/BukkitImplDeprecations.java +++ b/plugin/src/main/java/com/denizenscript/denizen/utilities/BukkitImplDeprecations.java @@ -240,6 +240,9 @@ public class BukkitImplDeprecations { public static Warning assignmentRemove = new VerySlowWarning("assignmentRemove", "'assignment remove' without a script is deprecated: use 'clear' to clear all scripts, or 'remove' to remove one at a time."); public static Warning npcScriptSingle = new VerySlowWarning("npcScriptSingle", "'npc.script' is deprecated in favor of 'npc.scripts' (plural)."); + // Added 2023/07/21, bump when 1.17 is gone. + public static Warning chunkRefreshSections = new VerySlowWarning("chunkRefreshSections", "ChunkTag.refresh_chunk_sections, as of MC 1.18, is just a replica of ChunkTag.refresh_chunk, and so that mech should be used instead."); + // ==================== FUTURE deprecations ==================== // Added 2021/03/27, deprecate officially by 2024.