From b62926ec0fc753fabde76c5a139b4311c3044494 Mon Sep 17 00:00:00 2001
From: "Alex \"mcmonkey\" Goodwin" <git_commits@alexgoodwin.dev>
Date: Sat, 5 Aug 2023 18:34:15 -0700
Subject: [PATCH] strip the display tag from items when setting lore to empty

---
 .../denizen/nms/v1_19/helpers/ItemHelperImpl.java            | 5 ++++-
 .../denizen/nms/v1_20/helpers/ItemHelperImpl.java            | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java b/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java
index 8b3068239c..789e8dab6c 100644
--- a/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java
+++ b/v1_19/src/main/java/com/denizenscript/denizen/nms/v1_19/helpers/ItemHelperImpl.java
@@ -338,7 +338,10 @@ public void setLore(ItemTag item, List<String> lore) {
             tag.put("display", display);
         }
         if (lore == null || lore.isEmpty()) {
-            display.put("Lore", null);
+            display.remove("Lore");
+            if (display.isEmpty()) {
+                tag.remove("display");
+            }
         }
         else {
             ListTag tagList = new ListTag();
diff --git a/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java b/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java
index 0a44d579af..151ce0ebcc 100644
--- a/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java
+++ b/v1_20/src/main/java/com/denizenscript/denizen/nms/v1_20/helpers/ItemHelperImpl.java
@@ -353,7 +353,10 @@ public void setLore(ItemTag item, List<String> lore) {
             tag.put("display", display);
         }
         if (lore == null || lore.isEmpty()) {
-            display.put("Lore", null);
+            display.remove("Lore");
+            if (display.isEmpty()) {
+                tag.remove("display");
+            }
         }
         else {
             ListTag tagList = new ListTag();