From b719b5b211210f1aee6e6422f057e45c80074c24 Mon Sep 17 00:00:00 2001 From: mcmonkey4eva Date: Tue, 14 Jul 2015 03:03:13 -0700 Subject: [PATCH] Hanging breaks - entity -> breaker --- .../EntityBreaksHangingScriptEvent.java | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/main/java/net/aufdemrand/denizen/events/entity/EntityBreaksHangingScriptEvent.java b/src/main/java/net/aufdemrand/denizen/events/entity/EntityBreaksHangingScriptEvent.java index 618b6ca630..c22153cdf6 100644 --- a/src/main/java/net/aufdemrand/denizen/events/entity/EntityBreaksHangingScriptEvent.java +++ b/src/main/java/net/aufdemrand/denizen/events/entity/EntityBreaksHangingScriptEvent.java @@ -33,12 +33,11 @@ public class EntityBreaksHangingScriptEvent extends BukkitScriptEvent implements // @Triggers when a hanging entity (painting, item_frame, or leash_hitch) is broken. // // @Context - // returns the cause of the entity breaking. - // returns the dEntity that broke the hanging entity, if any. + // returns the cause of the entity breaking. Causes list: <@link url http://bit.ly/1BeqxPX> + // returns the dEntity that broke the hanging entity, if any. // returns the dEntity of the hanging. // DEPRECATED. // DEPRECATED. - // Causes list: <@link url http://bit.ly/1BeqxPX> // // --> @@ -48,7 +47,7 @@ public EntityBreaksHangingScriptEvent() { public static EntityBreaksHangingScriptEvent instance; public Element cause; - public dEntity entity; + public dEntity breaker; public dEntity hanging; public dList cuboids; public dLocation location; @@ -66,7 +65,7 @@ public boolean matches(ScriptContainer scriptContainer, String s) { String lower = CoreUtilities.toLowerCase(s); String entName = CoreUtilities.getXthArg(0, lower); String hang = CoreUtilities.getXthArg(2, lower); - if (!entity.matchesEntity(entName)) { + if (!breaker.matchesEntity(entName)) { return false; } if (!hang.equals("hanging") && !hanging.matchesEntity(hang)) { @@ -106,15 +105,17 @@ public boolean applyDetermination(ScriptContainer container, String determinatio @Override public ScriptEntryData getScriptEntryData() { - return new BukkitScriptEntryData(entity.isPlayer() ? entity.getDenizenPlayer() : null, - entity.isCitizensNPC() ? entity.getDenizenNPC() : null); + // TODO: What if the hanging is an NPC? + return new BukkitScriptEntryData(breaker.isPlayer() ? breaker.getDenizenPlayer() : null, + breaker.isCitizensNPC() ? breaker.getDenizenNPC() : null); } @Override public HashMap getContext() { HashMap context = super.getContext(); context.put("cause", cause); - context.put("entity", entity); + context.put("entity", breaker); // NOTE: Deprecated + context.put("breaker", breaker); context.put("hanging", hanging); context.put("cuboids", cuboids); context.put("location", location); @@ -126,7 +127,7 @@ public void onHangingBreaks(HangingBreakByEntityEvent event) { hanging = new dEntity(event.getEntity()); cause = new Element(event.getCause().name()); location = new dLocation(hanging.getLocation()); - entity = new dEntity(event.getRemover()); + breaker = new dEntity(event.getRemover()); cuboids = new dList(); for (dCuboid cuboid : dCuboid.getNotableCuboidsContaining(location)) { cuboids.add(cuboid.identifySimple());