Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to include a 'pause' at the end of a typed line before the next line begins #118

Closed
jsolly opened this issue Aug 5, 2022 · 4 comments · Fixed by #119
Closed
Labels
enhancement New feature or request

Comments

@jsolly
Copy link

jsolly commented Aug 5, 2022

is your feature request related to a problem? Please describe.

There currently isn't a way to pause the animation once it has finished typing. The motivation is that I want users to be able to read the typed sentence for a couple of seconds before the next line kicks off. I've gotten comments from nearly everyone who has reviewed my portfolio that they wish there was more time before the next line types.

The current implementation quickly goes to the next line after the current line has finished typing.

Describe the solution you'd like

I would like the animation to stop at the end of the line for a specified time. After that time has passed, the next line begins.

Describe alternatives you've considered

I tried adding lots of spaces at the end of the line, but that doesn't appear to lengthen the time the line is on screen.

The duration property isn't what I am looking for because that slows down the whole animation instead of adding a pause at the end of the line.

@jsolly jsolly added the enhancement New feature or request label Aug 5, 2022
@DenverCoder1 DenverCoder1 added this to To do in Readme Typing SVG Projects via automation Aug 5, 2022
@DenverCoder1
Copy link
Owner

Note that the duration is the time it takes to draw the text path from the left to the right of the full image width.

One alternative option you have is to increase the width parameter to make extra space around the text. This empty space will be included in the duration and should allow you create a "pause".

A pause parameter with a duration may be a useful addition though as it would make it more intuitive and not require increasing the image size.

Let me know what you think

@jsolly
Copy link
Author

jsolly commented Aug 6, 2022

Thanks for the reply!

I do see that increasing the width does accomplish what I am looking for. The only issue is that the large length of the image is breaking my layout.

I want the SVG to be centered, so if I am increasing the image width, it pushes the svg off-center visually. Can you think of a way to keep the text centered while also increasing the width to achieve a 'pause' ?

Readme Typing SVG Projects automation moved this from To do to Done Aug 8, 2022
@DenverCoder1
Copy link
Owner

Let me know what you think of the solution added in #119

@jsolly
Copy link
Author

jsolly commented Aug 8, 2022

Beautifully implemented. I added the pause param right away. Check it out on my portfolio page! 🚀

I have a link to your repo on my works cited page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants