Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show version status information on dependency graph nodes #2273

Conversation

rbt-mm
Copy link
Contributor

@rbt-mm rbt-mm commented Dec 12, 2022

Description

The information about the version status of a component is currently not displayed in the dependency graph, forcing users to switch to a different project tab, if they want to know about the version status.

This PR enhances the dependency graph to optionally display the version status information of a component on its corresponding node.

Addressed Issue

Frontend: #358

Additional Details

Frontend PR

Note: For the sake of better readability, the version status icon will only be shown for outdated components.

image

image

image

Checklist

  • I have read and understand the contributing guidelines
    - [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
    - [ ] This PR introduces changes to the database model, and I have added corresponding update logic
    - [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

@nscuro
Copy link
Member

nscuro commented Dec 15, 2022

@rbt-mm Thanks for the PR! I'd like to postpone merging this until the graph loading has a smaller footprint than it does currently, as this adds yet another step for every single component in the graph.

@nscuro nscuro added this to the 4.8 milestone Dec 15, 2022
@rbt-mm rbt-mm marked this pull request as draft December 16, 2022 13:22
Optionally includes `RepositoryMetaData` of a component in the response
of `getComponentByUuid` if query parameter `includeRepositoryMetaData`
is true.

Includes `RepositoryMetaData` of a component in the response of
`getDependencyGraphForComponent`

Signed-off-by: RBickert <rbt@mm-software.com>
Signed-off-by: RBickert <rbt@mm-software.com>
Signed-off-by: RBickert <rbt@mm-software.com>
Signed-off-by: RBickert <rbt@mm-software.com>
@rbt-mm rbt-mm force-pushed the master-show-update-available-icon-on-dependency-graph-nodes branch from 05bea34 to 5b4a706 Compare December 20, 2022 14:00
@rbt-mm rbt-mm marked this pull request as ready for review December 20, 2022 14:37
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rbt-mm! 🎉

I'll merge once the comments in the frontend PR are resolved.

@nscuro nscuro merged commit c03c8c2 into DependencyTrack:master Jan 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants