From db1af97b35d7d839e0ad3faecdec379433e856c4 Mon Sep 17 00:00:00 2001 From: Jumpei Matsuda Date: Thu, 14 Mar 2024 17:28:07 +0900 Subject: [PATCH 1/2] feat: Add com.deploygate.sdk.artifact_version to meta-tag This must be same as the released artifact version --- build.gradle | 1 + sdk.build.gradle | 3 ++- sdk/src/main/AndroidManifest.xml | 5 +++++ sdk/src/main/java/com/deploygate/sdk/HostApp.java | 3 +++ sdk/src/test/java/com/deploygate/sdk/HostAppTest.java | 1 + 5 files changed, 12 insertions(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 8954213..c03a21e 100644 --- a/build.gradle +++ b/build.gradle @@ -1,5 +1,6 @@ // Top-level build file where you can add configuration options common to all sub-projects/modules. ext { + // sdk/java/com/deploygate/sdk/HostAppTest.java needs to be changed for a new release releaseVersion = '4.6.1' } diff --git a/sdk.build.gradle b/sdk.build.gradle index 5a31a42..b15dc8d 100644 --- a/sdk.build.gradle +++ b/sdk.build.gradle @@ -37,7 +37,8 @@ android { manifestPlaceholders += [ featureFlags: flags, - sdkVersion: "4" + sdkVersion: "4", + sdkArtifactVersion: project.version, ] } diff --git a/sdk/src/main/AndroidManifest.xml b/sdk/src/main/AndroidManifest.xml index 914a0b1..3492e35 100644 --- a/sdk/src/main/AndroidManifest.xml +++ b/sdk/src/main/AndroidManifest.xml @@ -14,6 +14,11 @@ android:value="${sdkVersion}" /> + + Date: Thu, 14 Mar 2024 17:32:05 +0900 Subject: [PATCH 2/2] feat: Send an artifact version with INIT event --- sdk/src/main/java/com/deploygate/sdk/DeployGate.java | 1 + .../java/com/deploygate/service/DeployGateEvent.java | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/sdk/src/main/java/com/deploygate/sdk/DeployGate.java b/sdk/src/main/java/com/deploygate/sdk/DeployGate.java index 9265236..d9b1420 100644 --- a/sdk/src/main/java/com/deploygate/sdk/DeployGate.java +++ b/sdk/src/main/java/com/deploygate/sdk/DeployGate.java @@ -361,6 +361,7 @@ private void requestServiceInit(final boolean isBoot) { args.putBoolean(DeployGateEvent.EXTRA_CAN_LOGCAT, mHostApp.canUseLogcat); args.putString(DeployGateEvent.EXTRA_EXPECTED_AUTHOR, mExpectedAuthor); args.putInt(DeployGateEvent.EXTRA_SDK_VERSION, mHostApp.sdkVersion); + args.putString(DeployGateEvent.EXTRA_SDK_ARTIFACT_VERSION, mHostApp.sdkArtifactVersion); try { mRemoteService.init(mRemoteCallback, mHostApp.packageName, args); } catch (RemoteException e) { diff --git a/sdk/src/main/java/com/deploygate/service/DeployGateEvent.java b/sdk/src/main/java/com/deploygate/service/DeployGateEvent.java index f188c50..f45f95f 100644 --- a/sdk/src/main/java/com/deploygate/service/DeployGateEvent.java +++ b/sdk/src/main/java/com/deploygate/service/DeployGateEvent.java @@ -29,7 +29,18 @@ public interface DeployGateEvent { public static final String EXTRA_AUTHOR = "author"; public static final String EXTRA_EXPECTED_AUTHOR = "expectedAuthor"; + + /** + * A SDK's model version queried by this key from INIT event. + */ public static final String EXTRA_SDK_VERSION = "sdkVersion"; + + /** + * A SDK's artifact version queried by this key from INIT event. + * + * @since 4.7.0 + */ + public static final String EXTRA_SDK_ARTIFACT_VERSION = "e.sdk-artifact-version"; public static final String EXTRA_IS_MANAGED = "isManaged"; public static final String EXTRA_IS_AUTHORIZED = "isAuthorized"; public static final String EXTRA_LOGIN_USERNAME = "loginUsername";