Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support App Bundle Part 1 #60

Open
jmatsu opened this Issue Jan 27, 2019 · 4 comments

Comments

Projects
None yet
1 participant
@jmatsu
Copy link
Member

jmatsu commented Jan 27, 2019

The approach is to build a universal apk by bundletool from App Bundle.

Links

@jmatsu

This comment has been minimized.

Copy link
Member Author

jmatsu commented Jan 27, 2019

Split modules cannot be available by assembling an apk so we need to build it from App Bundle.
However, android.databinding.layouts.BindingInfo will be duplicate so D8 cannot create dex files. So it means we cannot create a univesal apk if dynamic modules enable DataBinding without any hack.

@jmatsu

This comment has been minimized.

Copy link
Member Author

jmatsu commented Feb 10, 2019

It sounds #60 (comment) has been solved by upgrading R8. Maybe it was a bug fortunately. 👀

@jmatsu

This comment has been minimized.

Copy link
Member Author

jmatsu commented Feb 10, 2019

  • How to retrieve bundletool
  • How to retrieve aapt2 for bundletool (the doc says the binary is different from build-tools' 🤔 )
@jmatsu

This comment has been minimized.

Copy link
Member Author

jmatsu commented Feb 17, 2019

til we support this feature, https://github.com/DroidKaigi/conference-app-2019/blob/e714989139f182fe499b1b3d4d4a4f5e8b9cd9cc/scripts/create_universal_apk_from_aab.bash is good for this.

Not integrated but I had prepared a sample.

def buildUniversalApk = project.tasks.create("buildUniversalApk", DefaultTask.class) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.