Dynamic FDVerifier #418
Merged
Dynamic FDVerifier #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUYT-1
requested changes
Jun 3, 2024
rpuwa
force-pushed
the
rpuwa_dynfd_validation
branch
3 times, most recently
from
bfc8879
to
506bcdf
Compare
BUYT-1
requested changes
Jun 7, 2024
BUYT-1
requested changes
Jun 12, 2024
src/core/config/tabular_data/crud_operations/update_in_place/option.h
Outdated
Show resolved
Hide resolved
BUYT-1
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Just the things I caught for now.
Look for similar things in the rest of the code yourself:
- Repeated lookups (ex: same things repeating inside
[]calls for attention) - Fields with generic names (ex:
a.first,a.second,a.second) used many times in a row is suspicious - Invariants not spelled out explicitly. If you just see the function and want to write an
assert, write it or make it such that it holds "automatically". Another class won't hurt. - Consider using more type aliases. It's hard to know which
std::vector<int>is a collection of value IDs and which is a collection of record IDs.
The less context you need to understand to figure out what's happening in a function, the better. Be more thorough with names.
BUYT-1
reviewed
Jun 15, 2024
rpuwa
force-pushed
the
rpuwa_dynfd_validation
branch
from
cea2091
to
ab8543e
Compare
BUYT-1
requested changes
Jun 16, 2024
src/core/algorithms/fd/fd_verifier/dynamic_stats_calculator.cpp
Outdated
Show resolved
Hide resolved
BUYT-1
requested changes
Jun 22, 2024
rpuwa
force-pushed
the
rpuwa_dynfd_validation
branch
2 times, most recently
from
9e7ad04
to
8ae9067
Compare
BUYT-1
approved these changes
Jun 24, 2024
rpuwa
force-pushed
the
rpuwa_dynfd_validation
branch
from
8ae9067
to
d6f2fa2
Compare
rpuwa
force-pushed
the
rpuwa_dynfd_validation
branch
from
d6f2fa2
to
a01f9d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.