Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with GitHub repo containing - (hyphen) #13

Closed
DesiQuintans opened this issue Feb 18, 2019 · 1 comment
Closed

Error with GitHub repo containing - (hyphen) #13

DesiQuintans opened this issue Feb 18, 2019 · 1 comment

Comments

@DesiQuintans
Copy link
Owner

@DesiQuintans DesiQuintans commented Feb 18, 2019

Encountered this issue when trying to install Brooke Watson's BRRR package:

shelf(brooke-watson/BRRR)

## Error in class(xx) <- cl : attempt to set an attribute on NULL 

Suspect it has something to do with the - in the name.

@DesiQuintans
Copy link
Owner Author

@DesiQuintans DesiQuintans commented Feb 18, 2019

This issue was created inside librarian:::nse_dots() when bare names were converted into character strings because alist() formats it as if it was an expression: "object brooke minus object watson".

brooke-watson/BRRR
  ↓
"brooke - watson/BRRR"

nse_dots() now removes spaces from its results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.