Format times in clarity stats as mm:ss #9534
Conversation
There was a problem hiding this comment.
It looks like we aren't showing sub-second differences anymore, which is necessary for stats like Time to Full HP
Unsure about the s suffix when the duration has a minutes component - 9:32s doesn't read like a duration to me. Perhaps we should drop the unit suffix for durations and always include the minutes segment?
Sub-60s cooldowns are a bit more verbose, but maybe that's an ok trade-off?
If we go with this, the relative horizontal alignment between rows with units vs. without looks a bit weird. We could possibly merge the value and units columns:
Furthermore, if we're not trying to keep all the units lined up, we could format durations like 10m 38s / 42s / 7.3s instead (or even use a localised representation). We'd probably only want to include the decimal point if at least one value on the row has a fractional component.
|
Makes sense - I think I've got something that should work. |
Fixes #9533. I struggled with what to show in the units column and decided that still showing "s" was appropriate.