New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow issue when selecting month/year #164

Closed
nathanhornby opened this Issue Nov 19, 2014 · 18 comments

Comments

Projects
None yet
3 participants
@nathanhornby

nathanhornby commented Nov 19, 2014

See screenshot attached. Can't access much of the select options as they're obscured by the overflow:hidden (I assume?) property.

screen shot 2014-11-19 at 14 50 27

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

Hey Nathan, I do not see the problem on this screen shot... Can you sent a larger one please ?

Member

nitriques commented Nov 19, 2014

Hey Nathan, I do not see the problem on this screen shot... Can you sent a larger one please ?

@nathanhornby

This comment has been minimized.

Show comment
Hide comment
@nathanhornby

nathanhornby Nov 19, 2014

You can't see the blank white space above the select options? They're being
cut off, that isn't the edge of the image :)

On Wed, Nov 19, 2014 at 3:09 PM, Nicolas Brassard notifications@github.com
wrote:

Hey Nathan, I do not see the problem on this screen shot... Can you sent a
larger one please ?


Reply to this email directly or view it on GitHub
#164 (comment).

nathanhornby commented Nov 19, 2014

You can't see the blank white space above the select options? They're being
cut off, that isn't the edge of the image :)

On Wed, Nov 19, 2014 at 3:09 PM, Nicolas Brassard notifications@github.com
wrote:

Hey Nathan, I do not see the problem on this screen shot... Can you sent a
larger one please ?


Reply to this email directly or view it on GitHub
#164 (comment).

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

You can't see the blank white space above the select options? They're being
cut off, that isn't the edge of the image :)

Oh. My. God. Sorry!

So the field is the first field in that column I guess ?

Member

nitriques commented Nov 19, 2014

You can't see the blank white space above the select options? They're being
cut off, that isn't the edge of the image :)

Oh. My. God. Sorry!

So the field is the first field in that column I guess ?

@nathanhornby

This comment has been minimized.

Show comment
Hide comment
@nathanhornby

nathanhornby Nov 19, 2014

Ha no problem, I can see where the confusion was!

I've got a better screenshot for you:

screen shot 2014-11-19 at 15 17 28

Oh, also this is Chrome 38.0.2125.122 on OSX 10.9.5

nathanhornby commented Nov 19, 2014

Ha no problem, I can see where the confusion was!

I've got a better screenshot for you:

screen shot 2014-11-19 at 15 17 28

Oh, also this is Chrome 38.0.2125.122 on OSX 10.9.5

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

Ok. Do you have a fix ? Right now, my 2.6.0 dev setup is kind of screwed since this extensions conflicts with the latest integration. If you can produce a fix, I could merge it and release it before doing the needed work for 2.6.0.

If not, I'll try to fix it, but I can't give any ETA on that.

Member

nitriques commented Nov 19, 2014

Ok. Do you have a fix ? Right now, my 2.6.0 dev setup is kind of screwed since this extensions conflicts with the latest integration. If you can produce a fix, I could merge it and release it before doing the needed work for 2.6.0.

If not, I'll try to fix it, but I can't give any ETA on that.

@nathanhornby

This comment has been minimized.

Show comment
Hide comment
@nathanhornby

nathanhornby Nov 19, 2014

I'm afraid I don't - I had a quick look but nothing obvious stood out - I
imagine there's an overflow rule in place for good reason that's
conflicting with it, so likely not a simple solution.

On Wed, Nov 19, 2014 at 3:23 PM, Nicolas Brassard notifications@github.com
wrote:

Ok. Do you have a fix ? Right now, my 2.6.0 dev setup is kind of screwed
since this extensions conflicts with the latest integration. If you can
produce a fix, I could merge it and release it before doing the needed work
for 2.6.0.

If not, I'll try to fix it, but I can't give any ETA on that.


Reply to this email directly or view it on GitHub
#164 (comment).

nathanhornby commented Nov 19, 2014

I'm afraid I don't - I had a quick look but nothing obvious stood out - I
imagine there's an overflow rule in place for good reason that's
conflicting with it, so likely not a simple solution.

On Wed, Nov 19, 2014 at 3:23 PM, Nicolas Brassard notifications@github.com
wrote:

Ok. Do you have a fix ? Right now, my 2.6.0 dev setup is kind of screwed
since this extensions conflicts with the latest integration. If you can
produce a fix, I could merge it and release it before doing the needed work
for 2.6.0.

If not, I'll try to fix it, but I can't give any ETA on that.


Reply to this email directly or view it on GitHub
#164 (comment).

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

so likely not a simple solution.

In fact. What Symphony version are you running ?

Member

nitriques commented Nov 19, 2014

so likely not a simple solution.

In fact. What Symphony version are you running ?

@nathanhornby

This comment has been minimized.

Show comment
Hide comment
@nathanhornby

nathanhornby Nov 19, 2014

Latest, 2.5.2

On Wed, Nov 19, 2014 at 3:29 PM, Nicolas Brassard notifications@github.com
wrote:

so likely not a simple solution.

In fact. What Symphony version are you running ?


Reply to this email directly or view it on GitHub
#164 (comment).

nathanhornby commented Nov 19, 2014

Latest, 2.5.2

On Wed, Nov 19, 2014 at 3:29 PM, Nicolas Brassard notifications@github.com
wrote:

so likely not a simple solution.

In fact. What Symphony version are you running ?


Reply to this email directly or view it on GitHub
#164 (comment).

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

Ok thanks.

Member

nitriques commented Nov 19, 2014

Ok thanks.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 19, 2014

Collaborator

What about setting overflow to visible for date and time fields?
I think there was a core change to the field CSS a while back.

Collaborator

nilshoerrmann commented Nov 19, 2014

What about setting overflow to visible for date and time fields?
I think there was a core change to the field CSS a while back.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

Yeah we've got that covered

.field-datetime .frame {
overflow: visible;
margin-bottom: 21px;
width: 100%;
}

But this is why it's there

.collapsible .instance {
overflow: hidden;
}

Maybe the collapsible should add visible overflow when fully expanded (it's needed when closed or animating)

Member

nitriques commented Nov 19, 2014

Yeah we've got that covered

.field-datetime .frame {
overflow: visible;
margin-bottom: 21px;
width: 100%;
}

But this is why it's there

.collapsible .instance {
overflow: hidden;
}

Maybe the collapsible should add visible overflow when fully expanded (it's needed when closed or animating)

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 19, 2014

Collaborator

You're right, so this needs to get fixed in the core.

Collaborator

nilshoerrmann commented Nov 19, 2014

You're right, so this needs to get fixed in the core.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

Sadly, yes.

Member

nitriques commented Nov 19, 2014

Sadly, yes.

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 19, 2014

Member

I'll try to send a PR today.

Member

nitriques commented Nov 19, 2014

I'll try to send a PR today.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 19, 2014

Collaborator

Thanks a lot, Nicolas!

Collaborator

nilshoerrmann commented Nov 19, 2014

Thanks a lot, Nicolas!

nitriques added a commit to DeuxHuitHuit/symphonycms that referenced this issue Nov 20, 2014

Overflow visible when collapsible is expanded
This fixes a bug where the content of the collapsible was cut-off.

Re: DeuxHuitHuit/datetime#164
@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 20, 2014

Member

PR Sent! Thanks again @nathanhornby for reporting! If you want it fixed in your current setup, please apply the 65aac00 patch to your css and run grunt css.

Member

nitriques commented Nov 20, 2014

PR Sent! Thanks again @nathanhornby for reporting! If you want it fixed in your current setup, please apply the 65aac00 patch to your css and run grunt css.

@nilshoerrmann

This comment has been minimized.

Show comment
Hide comment
@nilshoerrmann

nilshoerrmann Nov 20, 2014

Collaborator

Thanks!

Collaborator

nilshoerrmann commented Nov 20, 2014

Thanks!

@nitriques

This comment has been minimized.

Show comment
Hide comment
@nitriques

nitriques Nov 20, 2014

Member

My pleasure!

Member

nitriques commented Nov 20, 2014

My pleasure!

nitriques added a commit to DeuxHuitHuit/symphonycms that referenced this issue Feb 19, 2015

Overflow visible when collapsible is expanded
This fixes a bug where the content of the collapsible was cut-off.

Re: DeuxHuitHuit/datetime#164
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment