fix: resolve lint issues in analytics route (#174)

[qorexdevs]

Summary Fixes ESLint issues in apps/backend/src/routes/analytics.ts for issue #174 by removing unused handler args, avoiding unbound method usage for auth preHandler, and adding an explicit return type. Closes #174 --- ## Type of Change - [x] Bug fix - [ ] New feature - [ ] Refactor (no functional change) - [ ] UI / Design change - [ ] Tests only - [ ] Documentation - [ ] Infrastructure / DevOps - [ ] Security --- ## What Changed - Added Promise<void> return type to analyticsRoutes. - Replaced per-route preHandler: [app.authenticate] with a hook wrapper call to avoid @typescript-eslint/unbound-method. - Removed unused FastifyReply import and unused reply args from analytics handlers. --- ## How to Test 1. pnpm install 2. cd apps/backend 3. pnpm exec eslint src/routes/analytics.ts --- ## Checklist - [ ] My code follows the project's coding style (pnpm -r run lint passes). - [ ] TypeScript compiles without errors (pnpm -r run typecheck). - [ ] I have added or updated tests for the changes I made. - [ ] All tests pass locally (pnpm -r run test). - [ ] I have updated documentation where necessary. - [x] No new console.log or debug statements left in the code. - [ ] Breaking changes are documented in this PR description. --- ## Additional Context Scope is intentionally limited to apps/backend/src/routes/analytics.ts as requested in #174.

Terminal Proof

• apps/backend/node_modules/.bin/eslint src/routes/analytics.ts
• exit code 0

[qorexdevs]

Quick status: local lint proof is green for this scope (pnpm exec eslint src/routes/analytics.ts).
Current CI blocker is Vercel authorization for external PR deployments.

[Harxhit]

Quick status: local lint proof is green for this scope (pnpm exec eslint src/routes/analytics.ts). Current CI blocker is Vercel authorization for external PR deployments.

Could you please attach terminals proof in description.

[qorexdevs]

added the terminal proof to the PR description

[Harxhit]

added the terminal proof to the PR description

Sorry but I cannot see changes made in PR description.

[qorexdevs]

reran locally, terminal output:

$ pnpm --dir apps/backend exec eslint src/routes/analytics.ts
exit code: 0

also re-saved the PR description with the same proof block.

[Harxhit]

reran locally, terminal output:

$ pnpm --dir apps/backend exec eslint src/routes/analytics.ts
exit code: 0

also re-saved the PR description with the same proof block.

There is communication problem please attach proof like this for test command.

[qorexdevs]

reran from my local clone (DevCard):

ext PS C:\\Users\\qorex\\Desktop\\coding\\in_work\\github\\DevCard> pnpm --dir apps/backend exec eslint src/routes/analytics.ts PS C:\\Users\\qorex\\Desktop\\coding\\in_work\\github\\DevCard> echo 0

there is no eslint output for this file when it passes.

[qorexdevs]

reran on current head from local clone:

PS C:\Users\qorex\Desktop\coding\in_work\github\DevCard> pnpm --dir apps/backend exec eslint src/routes/analytics.ts
PS C:\Users\qorex\Desktop\coding\in_work\github\DevCard> $LASTEXITCODE
0

eslint prints no line output when this file passes, so exit code is the only signal here.
Vercel check still needs maintainer-side authorization for fork PR deployments.