Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection Settings Bug #17

Closed
benrick opened this issue Sep 6, 2019 · 0 comments · Fixed by #20
Closed

Collection Settings Bug #17

benrick opened this issue Sep 6, 2019 · 0 comments · Fixed by #20
Labels
Bug Something isn't working

Comments

@benrick
Copy link
Member

benrick commented Sep 6, 2019

The collections we have in our settings duplicate all of their values when loading the data from the json files.

We need to preserve the behavior of having defaults that will fill in even when we've added new items to the collection that didn't exist before, and we also need to prefer the data the user saved.
@benrick benrick added the Bug Something isn't working label Sep 6, 2019
@benrick benrick mentioned this issue Sep 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temp fix - remove duplicates after loading DevChatter/InteractiveSeven
1 participant
@benrick