Scheduler: Form customization

[aleksei-semikozov]

No description provided.

[Copilot]

Pull Request Overview

This PR adds form customization capabilities to the Scheduler's appointment popup by introducing an editing.items configuration option. This allows developers to control which form groups are displayed and customize their visibility and child items.

Key Changes:

• Implemented handleCustomizeFormItems method to process custom form item configurations
• Added name properties to all form groups (subjectGroup, dateRangeGroup, repeatGroup, descriptionGroup, resourcesGroup) to enable identification
• Added comprehensive test coverage for form customization scenarios

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts	Implements form customization logic and adds name properties to form groups
packages/devextreme/js/__internal/scheduler/appointment_popup/appointment_popup.test.ts	Adds test suite for form customization feature and skips two existing tests

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

[Copilot]

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

[Tucchhaa]

buildFormItemsMap is called only for defaultItems, which means that we will never have tab items here.

So I suggest:

if(isGroupItem(item)) {
  return buildFormItemsMap(item.items ?? [], accumulator)
}

return accumulator;

[Tucchhaa]

By the way this will not work if user has tabItem that uses a default item inside. But I suggest to postpone implementing this

[Tucchhaa]

I suggest to use a consistent naming in this file (yes, not only this function), because the same entities may have different names throughout the file which may be very confusing. For example, currently we have:

userConfig, config, configure which represent a custom item from user.

or variable name map doesn't tell anything about the variable except it's type, which I can already see by typescript.

So my suggestion is to rename entities like this:
map -> defaultItemsMap
configure -> customItems or userItems
existingItem -> defaultItem
config -> customItem or userItem
userConfig -> customItemsRoot or userItemsRoot

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packages/devextreme/js/__internal/scheduler/appointment_popup/m_form.ts:355

• This intermediate group lacks a name property, which breaks the hierarchical item path resolution used in updateDateTimeEditorsVisibility() at lines 918-921. The paths like mainGroup.dateGroup.startDateGroup.startDate won't work because DevExtreme Form's itemOption method can't traverse unnamed groups. Add a name property (e.g., name: 'dateGroupContent') and update the paths in updateDateTimeEditorsVisibility() to include this intermediate group name.

        {
          colSpan: 1,
          itemType: 'group',
          items: [
            this.createAllDaySwitch(),
            this.createStartDateGroup(),
            this.createEndDateGroup(),
          ],
        },