Skip to content

Conversation

@juleari
Copy link
Contributor

@juleari juleari commented Oct 30, 2025

No description provided.

@juleari juleari self-assigned this Oct 30, 2025
@juleari juleari requested a review from a team as a code owner October 30, 2025 09:00
Copilot AI review requested due to automatic review settings October 30, 2025 09:00
@juleari juleari added the 25_2 label Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the dropdown options tests by splitting a single large test file into two smaller test files (part1 and part2) to improve test execution parallelization. The main test logic is extracted into a reusable widgetTestModule function that can be called by multiple test files.

Key changes:

  • Extracted test module logic into an exportable function
  • Split test execution across two new test files (part1 and part2)
  • Each new file tests half of the dropdown editors list

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
dropDownOptions.tests.js Refactored to export widgetTestModule function; removed direct test execution and setup code
dropDownOptions.part1.tests.js New file that tests the first half of dropdown editors using the exported function
dropDownOptions.part2.tests.js New file that tests the second half of dropdown editors using the exported function
Comments suppressed due to low confidence (2)

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownParts/dropDownOptions.tests.js:4

  • The dropDownEditorsList import is missing but the variable is still referenced throughout the exported widgetTestModule function (e.g., line 156, 181, 203, etc.). Add import { dropDownEditorsList } from '../../../helpers/widgetsList.js'; to fix the ReferenceError that will occur when the function executes.
    packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownParts/dropDownOptions.tests.js:135
  • The arrow function has an extra opening parenthesis. Change to export const widgetTestModule = widgetName => { (remove the opening parenthesis before widgetName) or use proper syntax export const widgetTestModule = (widgetName) => {.

Copilot AI review requested due to automatic review settings October 30, 2025 13:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Copilot AI review requested due to automatic review settings October 30, 2025 13:56
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js:391

  • Removed incorrectly spelled option 'earButton' (likely a typo for 'clearButton').
                showClearButton: false,

Copilot AI review requested due to automatic review settings October 30, 2025 15:15
@juleari juleari changed the title QUnit tests: divined dropDownOptions to two files QUnit tests: divined editors tests to reduce tests per file Oct 30, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js:391

  • Corrected spelling of 'earButton' (removed line appears to be a typo)
                showClearButton: false,

Copilot AI review requested due to automatic review settings October 30, 2025 16:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.

@juleari juleari merged commit b74b838 into DevExpress:25_2 Oct 31, 2025
113 checks passed
juleari added a commit to juleari/DevExtreme that referenced this pull request Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants