-
Notifications
You must be signed in to change notification settings - Fork 654
QUnit tests: divined editors tests to reduce tests per file #31522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the dropdown options tests by splitting a single large test file into two smaller test files (part1 and part2) to improve test execution parallelization. The main test logic is extracted into a reusable widgetTestModule function that can be called by multiple test files.
Key changes:
- Extracted test module logic into an exportable function
- Split test execution across two new test files (part1 and part2)
- Each new file tests half of the dropdown editors list
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dropDownOptions.tests.js | Refactored to export widgetTestModule function; removed direct test execution and setup code |
| dropDownOptions.part1.tests.js | New file that tests the first half of dropdown editors using the exported function |
| dropDownOptions.part2.tests.js | New file that tests the second half of dropdown editors using the exported function |
Comments suppressed due to low confidence (2)
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownParts/dropDownOptions.tests.js:4
- The
dropDownEditorsListimport is missing but the variable is still referenced throughout the exportedwidgetTestModulefunction (e.g., line 156, 181, 203, etc.). Addimport { dropDownEditorsList } from '../../../helpers/widgetsList.js';to fix the ReferenceError that will occur when the function executes.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownParts/dropDownOptions.tests.js:135 - The arrow function has an extra opening parenthesis. Change to
export const widgetTestModule = widgetName => {(remove the opening parenthesis beforewidgetName) or use proper syntaxexport const widgetTestModule = (widgetName) => {.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownOptions.part2.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownOptions.part1.tests.js
Outdated
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js:391
- Removed incorrectly spelled option 'earButton' (likely a typo for 'clearButton').
showClearButton: false,
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownOptions.part1.tests.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 8 out of 10 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js:391
- Corrected spelling of 'earButton' (removed line appears to be a typo)
showClearButton: false,
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dropDownOptions.part5.tests.js
Show resolved
Hide resolved
packages/devextreme/testing/tests/DevExpress.ui.widgets.editors/dateRangeBox.tests.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
No description provided.