From bd49b0e9cdf6e61b5dd13a99ff39c33332df4c0e Mon Sep 17 00:00:00 2001 From: George Sobolev Date: Fri, 16 Jun 2017 12:15:28 +0300 Subject: [PATCH] refactor(react-grid): Rename detailToggleTemplate to detailToggleCellTemplate (#146) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit BREAKING CHANGE: We renamed the `detailToggleTemplate` property of the TableRowDetail plugin to `detailToggleCellTemplate` to make it consistent with the `detailToggleCellWidth` property. --- .../src/plugins/table-row-detail.jsx | 4 ++-- .../src/plugins/table-row-detail.jsx | 4 ++-- packages/dx-react-grid/docs/reference/table-row-detail.md | 2 +- packages/dx-react-grid/src/plugins/table-row-detail.jsx | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/packages/dx-react-grid-bootstrap3/src/plugins/table-row-detail.jsx b/packages/dx-react-grid-bootstrap3/src/plugins/table-row-detail.jsx index 6a6bc2fe1d..4eee5bda75 100644 --- a/packages/dx-react-grid-bootstrap3/src/plugins/table-row-detail.jsx +++ b/packages/dx-react-grid-bootstrap3/src/plugins/table-row-detail.jsx @@ -3,12 +3,12 @@ import { TableRowDetail as TableRowDetailBase } from '@devexpress/dx-react-grid' import { TableDetailToggleCell } from '../templates/table-detail-toggle-cell'; import { TableDetailCell } from '../templates/table-detail-cell'; -const detailToggleTemplate = props => ; +const detailToggleCellTemplate = props => ; const detailCellTemplate = props => ; export const TableRowDetail = props => ( ; +const detailToggleCellTemplate = props => ; const detailCellTemplate = props => ; export const TableRowDetail = props => ( ReactElement | | A component that renders row details detailCellTemplate | (args: [DetailCellArgs](#detail-cell-args)) => ReactElement | | A component that renders a detail cell -detailToggleTemplate | (args: [DetailToggleArgs](#detail-toggle-args)) => ReactElement | | A component that renders the detail toggle control +detailToggleCellTemplate | (args: [DetailToggleArgs](#detail-toggle-args)) => ReactElement | | A component that renders the detail toggle control detailToggleCellWidth | number | | Specifies the detail toggle cell width rowHeight | number | string | 'auto' | Specifies the detail row height diff --git a/packages/dx-react-grid/src/plugins/table-row-detail.jsx b/packages/dx-react-grid/src/plugins/table-row-detail.jsx index dddf2f77cb..be0d5588ce 100644 --- a/packages/dx-react-grid/src/plugins/table-row-detail.jsx +++ b/packages/dx-react-grid/src/plugins/table-row-detail.jsx @@ -8,7 +8,7 @@ export class TableRowDetail extends React.PureComponent { const { rowHeight, template, - detailToggleTemplate, + detailToggleCellTemplate, detailCellTemplate, detailToggleCellWidth, } = this.props; @@ -40,7 +40,7 @@ export class TableRowDetail extends React.PureComponent { expandedRows, setDetailRowExpanded, ...restParams - }) => detailToggleTemplate({ + }) => detailToggleCellTemplate({ ...restParams, expanded: isDetailRowExpanded(expandedRows, getRowId(row)), toggleExpanded: () => setDetailRowExpanded({ rowId: getRowId(row) }), @@ -71,7 +71,7 @@ export class TableRowDetail extends React.PureComponent { TableRowDetail.propTypes = { template: PropTypes.func, - detailToggleTemplate: PropTypes.func.isRequired, + detailToggleCellTemplate: PropTypes.func.isRequired, detailCellTemplate: PropTypes.func.isRequired, detailToggleCellWidth: PropTypes.number.isRequired, rowHeight: PropTypes.oneOfType([