New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-grid-bootstrap4): support the bootstrap4 theme #681

Merged
merged 92 commits into from Mar 2, 2018

Conversation

Projects
None yet
6 participants
@MaximKudriavtsev
Copy link
Contributor

MaximKudriavtsev commented Jan 18, 2018

No description provided.

@kvet kvet changed the title [wip]feat:(react-grid-bootstrap4) support the bootstrap4 theme [wip]feat(react-grid-bootstrap4): support the bootstrap4 theme Jan 18, 2018


- Material UI
- Bootstrap 4

This comment has been minimized.

@kvet

kvet Feb 21, 2018

Contributor

What about icons?

@@ -49,7 +57,9 @@ Use the Table plugin to display the data as a simple table:
```jsx
import {
Grid, Table, TableHeaderRow
} from '@devexpress/dx-react-grid-bootstrap3'/* or '@devexpress/dx-react-grid-material-ui' */;
} from '@devexpress/dx-react-grid-bootstrap4';

This comment has been minimized.

@kvet

kvet Feb 21, 2018

Contributor

I don't understand logic. We put the first MUI everywhere. Why do we put the first BS4 here?

"lint": "eslint \"src/**\"",
"lint:fix": "yarn run lint -- --fix"
},
"jest": {

This comment has been minimized.

@kvet

kvet Feb 21, 2018

Contributor

Is there any .ts tests? Why do you put this redundant configuration?

"prop-types": "^15.6.0"
},
"peerDependencies": {
"@devexpress/dx-grid-core": "1.0.0",

This comment has been minimized.

@kvet

kvet Feb 21, 2018

Contributor

The version was updated to 1.0.1

MaximKudriavtsev added some commits Feb 21, 2018

-moz-user-select: none;
-webkit-user-select: 'none';
}
.dx-rg-bs4-opacity-03 {

This comment has been minimized.

@SergeyAlexeev

SergeyAlexeev Feb 21, 2018

Contributor

I'd prefer to name it .dx-rg-bs4-inactive or something like this. I mean, use more abstract name.

@MaximKudriavtsev MaximKudriavtsev requested a review from viterobk Feb 22, 2018

@viterobk viterobk requested a review from dirk-pieterse Feb 27, 2018

dirk-pieterse added some commits Mar 1, 2018

@MaximKudriavtsev MaximKudriavtsev merged commit c3d58f0 into DevExpress:master Mar 2, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@MaximKudriavtsev MaximKudriavtsev deleted the MaximKudriavtsev:bs4-support branch Mar 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment