Avoid scrollbars in ShadowUI (closes #1138) #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyBelym
requested review from
VasilyStrelyaev,
helen-dikareva and
AlexanderMoskovkin
helen-dikareva
approved these changes
Jan 17, 2017
AlexanderMoskovkin
suggested changes
Jan 17, 2017
|
❌ Tests for the commit e51b119 have failed. See details: |
VasilyStrelyaev
approved these changes
Jan 18, 2017
|
❌ Tests for the commit e967f6e have failed. See details: |
|
✅ Tests for the commit e967f6e have passed. See details: |
|
FPR |
AlexanderMoskovkin
suggested changes
Jan 18, 2017
| .then(nextTick); | ||
| .then(nextTick) | ||
| .then(() => { | ||
| // var { x, y } = this._getTargetClientPoint(); |
|
❌ Tests for the commit 15081f2 have failed. See details: |
|
@testcafe-build-bot \retest |
AlexanderMoskovkin
approved these changes
Jan 19, 2017
|
❌ Tests for the commit 15081f2 have failed. See details: |
|
✅ Tests for the commit 15081f2 have passed. See details: |
AndreyBelym
changed the title
helen-dikareva
approved these changes
Jan 19, 2017
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
\cc @AlexanderMoskovkin @helen-dikareva @VasilyStrelyaev