create screenshot dir if plugin is used (closes #4477) #4488
Conversation
|
❌ Tests for the commit de57dd8 have failed. See details: |
|
❌ Tests for the commit de57dd8 have failed. See details: |
|
✅ Tests for the commit de57dd8 have passed. See details: |
AlexKamaev
requested review from
AndreyBelym and
miherlosev
and removed request for
miherlosev and
AndreyBelym
|
❌ Tests for the commit 30160f2 have failed. See details: |
src/browser/provider/index.ts
Outdated
| @@ -317,8 +319,11 @@ export default class BrowserProvider { | |||
| else | |||
| await this._takeLocalBrowserScreenshot(browserId, screenshotPath); | |||
There was a problem hiding this comment.
Looks like we won't create a directory in the code path where _takeLocalBrowserScreenshot is called.
There was a problem hiding this comment.
There was a problem hiding this comment.
It's very unobvious. At least, we should add a comment about it.
But I would prefer to refactor the code to get both cases covered by makeDir.
|
❌ Tests for the commit fa32b89 have failed. See details: |
|
❌ Tests for the commit fa32b89 have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit fa32b89 have failed. See details: |
|
@testcafe-build-bot retest |
|
✅ Tests for the commit fa32b89 have passed. See details: |
…Express#4488) * create screenshot dir if plugin is used (closes DevExpress#4477) * remove obsolete code * refactoring
I reverted the fix of #4303
Since it leaded to failure in custom browser provers
Now the dir will be created for all plugins but not for local browser.
For local browser the dir is created by
browser-tools