Skip to content

fix: remove leakless true as default #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2023
Merged

fix: remove leakless true as default #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/web/web.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type WebConfig struct {
// timeout value in seconds
timeout int32
headless bool
leakless bool
}

func NewWebConf(datadir string) *WebConfig {
Expand Down Expand Up @@ -58,7 +59,7 @@ func New(conf *WebConfig) *Web {
Devtools(false).
Headless(conf.headless).
UserDataDir(conf.datadir).
Leakless(true)
Leakless(conf.leakless)

url := l.MustLaunch()

Expand All @@ -76,7 +77,8 @@ func New(conf *WebConfig) *Web {
// GetSamlLogin performs a saml login for a given
func (web *Web) GetSamlLogin(conf credentialexchange.CredentialConfig) (string, error) {

// do not clean up userdata
// close browser even on error
// should cover most cases even with leakless: false
defer web.browser.MustClose()

web.browser.MustPage(conf.ProviderUrl)
Expand Down Expand Up @@ -117,6 +119,7 @@ func (web *Web) GetSSOCredentials(conf credentialexchange.CredentialConfig) (str
defer web.browser.MustClose()

web.browser.MustPage(conf.ProviderUrl)

router := web.browser.HijackRequests()
defer router.MustStop()

Expand Down