fix: ci

.github/workflows/build.yml

@@ -3,8 +3,6 @@ name: CI
 on:
   push:
     branches: [ master ]
-  pull_request:
-    branches: [ master ]
 
 jobs:
   build:

.github/workflows/pr.yml

@@ -0,0 +1,33 @@
+name: PR
+
+on:
+  pull_request:
+    branches: [ master, main ]
+
+jobs:
+  pr:
+    runs-on: ubuntu-latest
+    container:
+      image: golang:1.19-bullseye
+      env:
+        FOO: Bar
+        REVISION: $GITHUB_SHA
+      # ports:
+      #   - 80
+      # volumes:
+      #   - my_docker_volume:/volume_mount
+      # options: --cpus 1
+    steps:
+      - uses: actions/checkout@v3
+      - name: install deps
+        run: |
+          apt update && apt install jq -y
+          make REVISION=$GITHUB_SHA install
+      - name: make test 
+        run: |
+          make REVISION=$GITHUB_SHA test
+      - name: Publish Junit style Test Report
+        uses: mikepenz/action-junit-report@v3
+        if: always() # always run even if the previous step fails
+        with:
+          report_paths: '**/report-junit.xml'

.github/workflows/release.yml

@@ -1,8 +1,6 @@
 name: release
 
 on:
-  push:
-    branches: [ master ]
   workflow_run:
     workflows: ['CI']                     # runs after CI workflow
     types:

Makefile

@@ -1,7 +1,7 @@
 
 OWNER := dnitsch
 NAME := configmanager
-GIT_TAG := "1.17.0-pre"
+GIT_TAG := "1.17.1-pre"
 VERSION := "v$(GIT_TAG)"
 # VERSION := "$(shell git describe --tags --abbrev=0)"
 REVISION := $(shell git rev-parse --short HEAD)

README.md

@@ -13,7 +13,7 @@ Currently supported variable and secrets implementations:
 - [GCP Secrets](https://cloud.google.com/secret-manager)
 - [Hashicorp Vault](https://developer.hashicorp.com/vault/docs/secrets/kv)
 	- using the V2 endpoint
-	- see 
+	- see [special consideration hashivault](#special-consideration-for-hashicorpvault)
 
 The main driver is to use component level configuration objects, if stored in a `"namespaced"` manner e.g. in AWS ParamStore as `/nonprod/component-service-a/configVar`, however this is not a requirement and the param name can be whatever. Though whilst using some sort of a organised manner it will be more straight forward to allow other services to consume certain secrets/params based on resource/access policies.